Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better depth map versioning #2

Open
laplamgor opened this issue Aug 22, 2023 · 0 comments
Open

Better depth map versioning #2

laplamgor opened this issue Aug 22, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@laplamgor
Copy link
Owner

laplamgor commented Aug 22, 2023

Use hash (e.g. MD5) instead of version number for depth map download URL

Currently, the custom depth maps in this repo were versioned using in-game version numbers.
It requires a manual commit to update the version number when there are any Seasonal CG changes.
The version number does not match even if the same depth map existed in the server / repo.

Using hash also help deduplicate depth maps of ship IDs with same CG (some ships no-kai vs kai)

@laplamgor laplamgor added the enhancement New feature or request label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant