Update service provider to match signature of berkayk package #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LKaemmerling @mpociot If we could get this merged pretty soon that would be really nice. It's affecting production clients. Appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying berkayk/laravel-onesignal package updated from 2.2 to 2.3 and had a breaking change in the service provider implementation. There is a new API key that needs to be set as the 2nd argument. That inherently broke this package.
This PR updates the Service Provider argument signature to include the new API requirement. I've also updated the readme to tell users that they can set it in the config.
Right now I have it looking for the config value or falling back to a hard-coded
https://api.onesignal.comwhich is the new API endpoint that OneSignal is using. The oldhttps://onesignal.com/api/v1/will be deprecated of March 1, 2025.Troublesome Release: https://github.com/berkayk/laravel-onesignal/releases/tag/v2.3
Closes: #155