Allow multiple morphTo statements (#535)

Author: benjam-es

src/Generators/MigrationGenerator.php

@@ -56,7 +56,6 @@ public function output(Tree $tree, $overwrite = false): array
          */
         foreach ($tree->models() as $model) {
             $tables['tableNames'][$model->tableName()] = $this->populateStub($stub, $model);
-
             if (!empty($model->pivotTables())) {
                 foreach ($model->pivotTables() as $pivotSegments) {
                     $pivotTableName = $this->getPivotTableName($pivotSegments);
@@ -257,9 +256,13 @@ function ($modifier) use ($column) {
             $definition .= $column_definition;
         }
 
-        if ($model->morphTo()) {
-            $definition .= self::INDENT . sprintf('$table->unsignedBigInteger(\'%s\');', Str::lower($model->morphTo() . '_id')) . PHP_EOL;
-            $definition .= self::INDENT . sprintf('$table->string(\'%s\');', Str::lower($model->morphTo() . '_type')) . PHP_EOL;
+        $relationships = $model->relationships();
+
+        if (array_key_exists('morphTo', $relationships)) {
+            foreach ($relationships['morphTo'] as $morphTo) {
+                $definition .= self::INDENT . sprintf('$table->unsignedBigInteger(\'%s\');', Str::lower($morphTo . '_id')) . PHP_EOL;
+                $definition .= self::INDENT . sprintf('$table->string(\'%s\');', Str::lower($morphTo . '_type')) . PHP_EOL;
+            }
         }
 
         foreach ($model->indexes() as $index) {

src/Lexers/ModelLexer.php

@@ -158,10 +158,6 @@ private function buildModel(string $name, array $columns)
                 foreach ($columns['relationships'] as $type => $relationships) {
                     foreach (explode(',', $relationships) as $reference) {
                         $model->addRelationship(self::$relationships[strtolower($type)], trim($reference));
-
-                        if ($type === 'morphTo') {
-                            $model->setMorphTo(trim($reference));
-                        }
                     }
                 }
             }

src/Models/Model.php

@@ -12,7 +12,6 @@ class Model implements BlueprintModel
     private $primaryKey = 'id';
     private $timestamps = 'timestamps';
     private $softDeletes = false;
-    private $morphTo;
     private $columns = [];
     private $relationships = [];
     private $pivotTables = [];
@@ -189,14 +188,4 @@ public function polymorphicManyToManyTables()
     {
         return $this->polymorphicManyToManyTables;
     }
-
-    public function setMorphTo(string $reference)
-    {
-        $this->morphTo = $reference;
-    }
-
-    public function morphTo(): ?string
-    {
-        return $this->morphTo;
-    }
 }

tests/Feature/Generators/MigrationGeneratorTest.php

@@ -549,6 +549,31 @@ public function output_works_with_polymorphic_relationships()
         $this->assertEquals(['created' => [$post_migration, $user_migration, $image_migration]], $this->subject->output($tree));
     }
 
+    /**
+     * @test
+     */
+    public function output_works_with_multiple_morphto_statements_in_polymorphic_relationship()
+    {
+        $this->filesystem->expects('stub')
+            ->with('migration.stub')
+            ->andReturn($this->stub('migration.stub'));
+
+        $now = Carbon::now();
+        Carbon::setTestNow($now);
+
+        $image_migration = str_replace('timestamp', $now->format('Y_m_d_His'), 'database/migrations/timestamp_create_images_table.php');
+
+        $this->filesystem->expects('exists')->andReturn(false);
+
+        $this->filesystem->expects('put')
+            ->with($image_migration, $this->fixture('migrations/polymorphic_relationships_images_table_multiple_morphto.php'));
+
+        $tokens = $this->blueprint->parse($this->fixture('drafts/polymorphic-relationships-multiple-morphto.yaml'));
+        $tree = $this->blueprint->analyze($tokens);
+
+        $this->assertEquals(['created' => [$image_migration]], $this->subject->output($tree));
+    }
+
     /**
      * @test
      */

tests/Feature/Lexers/ModelLexerTest.php

@@ -632,7 +632,7 @@ public function it_enables_morphable_and_set_its_reference()
 
         $model = $actual['models']['Model'];
         $this->assertEquals('Model', $model->name());
-        $this->assertEquals('Morphable', $model->morphTo());
+        $this->assertArrayHasKey('morphTo', $model->relationships());
         $this->assertTrue($model->usesTimestamps());
 
         $columns = $model->columns();

tests/fixtures/drafts/polymorphic-relationships-multiple-morphto.yaml

@@ -0,0 +1,5 @@
+models:
+  Image:
+    url: string:400
+    relationships:
+      morphTo: Imageable, Tagable

tests/fixtures/migrations/polymorphic_relationships_images_table_multiple_morphto.php

@@ -0,0 +1,36 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+class CreateImagesTable extends Migration
+{
+    /**
+     * Run the migrations.
+     *
+     * @return void
+     */
+    public function up()
+    {
+        Schema::create('images', function (Blueprint $table) {
+            $table->id();
+            $table->string('url', 400);
+            $table->unsignedBigInteger('imageable_id');
+            $table->string('imageable_type');
+            $table->unsignedBigInteger('tagable_id');
+            $table->string('tagable_type');
+            $table->timestamps();
+        });
+    }
+
+    /**
+     * Reverse the migrations.
+     *
+     * @return void
+     */
+    public function down()
+    {
+        Schema::dropIfExists('images');
+    }
+}