[develop] Adds PHPUnit 11 support #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunomaduro
force-pushed
the
feat/phpunit11
branch
from
3a61b82
to
074e15c
Compare
|
Dropping a PHP version on a minor release is fine 👍 |
driesvints
approved these changes
Jan 11, 2024
driesvints
pushed a commit
that referenced
this pull request
Jan 12, 2024
* [7.x] Adds L11 support (#172) * Adds L11 support * Apply fixes from StyleCI * Reverts change * Fixes test suite * Excludes L11 on PHP 8.1 --------- Co-authored-by: StyleCI Bot <bot@styleci.io> * Removes `CreatesApplication` trait (#173) * Fixes workflow * Fixes test suite * Run tests on develop too * [develop] Adds PHPUnit 11 support (#175) * Uses attributes * Adds PHPUnit 11 support * Apply fixes from StyleCI --------- Co-authored-by: StyleCI Bot <bot@styleci.io> * Reverts `CreatesApplication` change * Fixes calling protected method --------- Co-authored-by: StyleCI Bot <bot@styleci.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for PHPUnit 11, similar to what we did in laravel/framework#49622. However, it needs dropping support for PHP 8.1. In my own packages, I don't view dropping a PHP version as a breaking change, since customers using PHP 8.1 won't receive the next minor version anyway. However, @driesvints, please share your thoughts! If you believe this should be a major version, we'll need to merge this into the develop branch and then merge develop into master.