Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Merges develop #176

Merged
merged 8 commits into from
Jan 12, 2024
Merged

[7.x] Merges develop #176

merged 8 commits into from
Jan 12, 2024

Conversation

nunomaduro
Copy link
Member

This pull request merges the work done on the develop branch

nunomaduro and others added 8 commits November 29, 2023 13:47
* Adds L11 support

* Apply fixes from StyleCI

* Reverts change

* Fixes test suite

* Excludes L11 on PHP 8.1

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
* Uses attributes

* Adds PHPUnit 11 support

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
@driesvints driesvints merged commit ab31fe7 into 7.x Jan 12, 2024
15 checks passed
@driesvints driesvints deleted the develop branch January 12, 2024 14:40
@eblount
Copy link

eblount commented Jan 16, 2024

@nunomaduro @driesvints Just wanted to let you guys know that this update caught a bug in our tests this morning. When upgrading to Laravel 10.41.0, a test started failing. Turns out we were referencing a model property ->see($model->address_1) instead of the correct ->address1. This worked for years because we were saying "see null in the page" and it was saying "sure, found null". This update helpfully started failing, requiring a string for HasSource::$source. Thanks for all the work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants