Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pint with --repair option does not exit but shows success instead #288

Open
Tamas-hi opened this issue Jul 30, 2024 · 1 comment
Open

Pint with --repair option does not exit but shows success instead #288

Tamas-hi opened this issue Jul 30, 2024 · 1 comment
Assignees

Comments

@Tamas-hi
Copy link

Pint Version

1.17.0

PHP Version

8.2.2

Description

According to the docs :

If you would like Pint to fix any files with code style errors but also exit with a non-zero exit code if any errors were fixed, you may use the --repair option:

./vendor/bin/pint --repair

However after creating a project with Laravel Breeze, this is the behavior I experience:

  1. --test correctly signals a formatting error and exits

./vendor/bin/pint --test

FAIL .............................................................................................................................................. 46 files, 1 style issue
⨯ routes/auth.php

  1. --repair correctly signals the formatting error, fixes it, but does not exist and returns with success:

./vendor/bin/pint --repair

FIXED ....................................................................................................................................... 46 files, 1 style issue fixed
✓ routes/auth.php

I think I should see a big red X in the last row instead of the green tick.

Steps To Reproduce

  1. Initialize a brand new laravel project with Laravel Breeze
  2. Run Laravel Pint with the option --repair.
@nunomaduro
Copy link
Member

@Tamas-hi can you try to understand why please? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants