wip

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>

Author: crynobone

phpstan.neon.dist

@@ -8,6 +8,5 @@ parameters:
   level: 8
 
   ignoreErrors:
-    - '#Call to an undefined method Illuminate\\Database\\ConnectionInterface::(getName|query)\(\)#'
-
-  checkMissingIterableValueType: false
+    - identifier: missingType.generics
+    - identifier: missingType.iterableValue

src/Eloquent.php

@@ -48,14 +48,16 @@ public static function serialize($builder): array
      * Unserialize to Eloquent Query Builder.
      *
      * @param  array{model: array<string, mixed>, builder: array<string, mixed>}  $payload
+     * @return \Illuminate\Database\Eloquent\Builder<\Illuminate\Database\Eloquent\Model>
      *
      * @phpstan-param  TPayload  $payload
      */
     public static function unserialize(array $payload): EloquentQueryBuilder
     {
-        $model = tap(new $payload['model']['class'](), static function ($model) use ($payload) {
-            $model->setConnection($payload['model']['connection']);
-        });
+        /** @var \Illuminate\Database\Eloquent\Model $model */
+        $model = new $payload['model']['class'];
+
+        $model->setConnection($payload['model']['connection']);
 
         // Register model global scopes to eloquent query builder, and
         // use $payload['model']['removedScopes'] to exclude

tests/Feature/EloquentTest.php

@@ -278,7 +278,7 @@ public function it_can_serialize_a_basic_eloquent_builder_with_belongs_to_many_j
     #[Test]
     public function it_can_serialize_a_related_eloquent_builder()
     {
-        $builder = (new User())->forceFill([
+        $builder = (new User)->forceFill([
             'id' => 5,
         ])->posts();
 

tests/Feature/HelpersTest.php

@@ -16,7 +16,7 @@ public function it_cannot_serialize_an_object()
         $this->expectException('InvalidArgumentException');
         $this->expectExceptionMessage('Unable to serialize $builder.');
 
-        serialize(new \Illuminate\Support\Fluent());
+        serialize(new \Illuminate\Support\Fluent);
     }
 
     #[Test]
@@ -25,6 +25,6 @@ public function it_cannot_unserialize_other_object()
         $this->expectException('InvalidArgumentException');
         $this->expectExceptionMessage('Unable to unserialize $payload.');
 
-        unserialize(new \Illuminate\Support\Fluent());
+        unserialize(new \Illuminate\Support\Fluent);
     }
 }

workbench/app/Models/Post.php

@@ -3,17 +3,17 @@
 namespace Workbench\App\Models;
 
 use Illuminate\Database\Eloquent\Model;
+use Illuminate\Database\Eloquent\Relations\BelongsTo;
 
 class Post extends Model
 {
+    /** {@inheritDoc} */
     protected $table = 'posts';
 
     /**
      * Belongs to relationship with User.
-     *
-     * @return \Illuminate\Database\Eloquent\Relations\BelongsTo
      */
-    public function user()
+    public function user(): BelongsTo
     {
         return $this->belongsTo(User::class);
     }