Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CSV format of Tastyworks #39

Open
andreasemer opened this issue Jul 20, 2024 · 9 comments
Open

New CSV format of Tastyworks #39

andreasemer opened this issue Jul 20, 2024 · 9 comments

Comments

@andreasemer
Copy link

The current version of the Pythonscript can no longer be used, the Tastyworks website only allows you to download the new CSV format. Are there plans to adapt the format?

@avion23
Copy link

avion23 commented Aug 15, 2024

Hello,
I have a similar project. I autogenerated a converter but haven't tried it out yet. I would appreciate your feedback.
https://github.com/avion23/tastyworksTaxes/blob/main/tastyworksTaxes/legacy.py

@quantx-heiko
Copy link
Contributor

I have adjusted the code for supporting the new Tastytrade data format exported from the Tastytrade App CSV export.
@laroche are you interested in incorporating this into your code?

@laroche
Copy link
Owner

laroche commented Sep 20, 2024

Yes, sure. I'd love to convert over to the new data format. Can you post your changes here on github or just
send them to my email address?

best regards,

Florian La Roche

@elsbrock
Copy link

@quantx-heiko is it available online?

@quantx-heiko
Copy link
Contributor

@elsbrock I just cloned the repo and did changes locally. So they're not online available yet.
@laroche However I did a couple of more changes to your original code than required for just the CSV format change e.g. added multipliers for other Futures. I also adjusted code to handle dates from the CSV as date object during processing instead of pure stings.
If it is OK for you I'd create a fork and a pull request with the necessary changes for the new format.

@laroche
Copy link
Owner

laroche commented Sep 21, 2024

Sounds like those additional changes should also be merged and extend the current version,
looking forward to see the changes. Pull request sounds great, any other format works as well.

@MiErnst
Copy link
Contributor

MiErnst commented Sep 22, 2024

As the format is the same as in #28, #28 can be closed as duplicate as it seems the work happens in this issue.

@quantx-heiko
Copy link
Contributor

@laroche find my code changes in pull request #42

@quantx-heiko
Copy link
Contributor

Issue #37 is also a duplicate of this issue and might be closed once the changes are incorporated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants