Work around Issue #2206

Possibly not the best fix, but for some reason MySqlRow.column_names is not being
populated. If a string index is requested and column_names is empty, fall back to
iterating over columns to try to find the column index.

Author: duelafn

sqlx-mysql/src/row.rs

@@ -42,10 +42,21 @@ impl Row for MySqlRow {
 
 impl ColumnIndex<MySqlRow> for &'_ str {
     fn index(&self, row: &MySqlRow) -> Result<usize, Error> {
-        row.column_names
-            .get(*self)
-            .ok_or_else(|| Error::ColumnNotFound((*self).into()))
-            .copied()
+        // Work around Issue #2206, <https://github.com/launchbadge/sqlx/issues/2206>
+        //
+        // column_names is empty so will always fail, but user expects this to work.
+        // Check the individual columns.
+        if row.column_names.is_empty() {
+            row.columns
+                .iter()
+                .find_map(|c| (*c.name == **self).then_some(c.ordinal))
+                .ok_or_else(|| Error::ColumnNotFound((*self).into()))
+        } else {
+            row.column_names
+                .get(*self)
+                .ok_or_else(|| Error::ColumnNotFound((*self).into()))
+                .copied()
+        }
     }
 }
 

tests/mysql/mysql.rs

@@ -636,3 +636,33 @@ async fn issue_3200() -> anyhow::Result<()> {
 
     Ok(())
 }
+
+#[sqlx_macros::test]
+async fn it_can_name_columns_issue_2206() -> anyhow::Result<()> {
+    let mut conn = new::<MySql>().await?;
+
+    sqlx::raw_sql(
+        "\
+        CREATE TABLE IF NOT EXISTS issue_2206
+        (
+            `id`                     BIGINT AUTO_INCREMENT,
+            `name`                   VARCHAR(128) NOT NULL,
+            PRIMARY KEY (id)
+        );
+    ",
+    )
+    .execute(&mut conn)
+    .await?;
+
+    let row = sqlx::query("INSERT INTO issue_2206 (name) VALUES (?) RETURNING *")
+        .bind("Alice")
+        .fetch_one(&mut conn)
+        .await?;
+
+    let _id: i64 = row.get("id");
+    let name: String = row.get("name");
+
+    assert_eq!(&name, "Alice");
+
+    Ok(())
+}