tuning workflow and adding some test exceptions for the moment

Author: tanderson-ld

.github/actions/contract-tests/action.yml

@@ -1,17 +1,21 @@
 name: Contract Tests
-description: Runs Contract Tests
+description: Runs Contract Tests (builds, starts service, runs SDK contract test harness)
 inputs:
   workspace_path:
-    description: 'Path to the package.'
+    description: 'Path to the package (e.g. lib/sdk/server).'
     required: true
   token:
     description: 'Github token, used for contract tests'
     required: false
     default: ''
+  test_harness_params:
+    description: 'Optional extra parameters for the SDK test harness (e.g. -enable-long-running-tests). Passed as TEST_HARNESS_PARAMS to make.'
+    required: false
+    default: ''
 
 runs:
   using: composite
   steps:
     - name: Run contract tests
       shell: bash
-      run: make contract-tests -C ${{ inputs.workspace_path }}
+      run: make contract-tests -C ${{ inputs.workspace_path }} TEST_HARNESS_PARAMS="${{ inputs.test_harness_params }}"

.github/workflows/nightly-contract-tests.yml

@@ -4,30 +4,37 @@ on:
   schedule:
     - cron: "0 4 * * *" # every day at 4am UTC
   workflow_dispatch:
+    inputs:
+      branch:
+        description: 'Branch to run contract tests on'
+        required: false
+        default: ''
+      test_slack_notification:
+        description: 'Also send a test Slack notification (to verify Slack integration)'
+        required: false
+        type: boolean
+        default: false
 
 jobs:
   nightly-contract-tests:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
+        with:
+          ref: ${{ inputs.branch || github.ref }}
 
       - name: Shared CI Steps
         uses: ./.github/actions/ci
         with:
           workspace_path: 'lib/sdk/server'
           java_version: 8
 
-      - name: Build Contract Tests
-        shell: bash
-        run: make build-contract-tests -C lib/sdk/server
-
-      - name: Start Contract Test Service
-        shell: bash
-        run: make start-contract-test-service-bg -C lib/sdk/server
-
-      - name: Run Contract Tests with Long-Running Tests
-        shell: bash
-        run: make run-contract-tests -C lib/sdk/server TEST_HARNESS_PARAMS="-enable-long-running-tests"
+      - name: Contract Tests (with long-running tests)
+        uses: ./.github/actions/contract-tests
+        with:
+          workspace_path: 'lib/sdk/server'
+          token: ${{ secrets.GITHUB_TOKEN }}
+          test_harness_params: '-enable-long-running-tests'
 
   notify-slack-on-failure:
     runs-on: ubuntu-latest
@@ -47,7 +54,7 @@ jobs:
                   "type": "section",
                   "text": {
                     "type": "mrkdwn",
-                    "text": ":warning: *Nightly Contract Tests Failed* :warning:\nThe nightly contract tests (with long-running tests enabled) failed on `main`."
+                    "text": ":warning: *Nightly Contract Tests Failed* :warning:\nThe nightly contract tests (with long-running tests enabled) failed on `${{ github.ref_name }}`."
                   },
                   "accessory": {
                     "type": "button",
@@ -60,3 +67,33 @@ jobs:
                 }
               ]
             }
+
+  test-slack-notification:
+    runs-on: ubuntu-latest
+    if: ${{ inputs.test_slack_notification == true || inputs.test_slack_notification == 'true' }}
+    steps:
+      - name: Send test Slack notification
+        uses: slackapi/slack-github-action@v2.1.0
+        with:
+          webhook: ${{ secrets.SLACK_WEBHOOK_URL }}
+          webhook-type: incoming-webhook
+          payload: |
+            {
+              "blocks": [
+                {
+                  "type": "section",
+                  "text": {
+                    "type": "mrkdwn",
+                    "text": ":white_check_mark: *Nightly Contract Tests – Slack test*\nThis is a test notification to verify Slack integration is working. Triggered manually from the Nightly Contract Tests workflow."
+                  },
+                  "accessory": {
+                    "type": "button",
+                    "text": {
+                      "type": "plain_text",
+                      "text": "View workflow run"
+                    },
+                    "url": "https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
+                  }
+                }
+              ]
+            }

lib/sdk/server/contract-tests/service/src/main/java/sdktest/TestService.java

@@ -41,6 +41,7 @@ public class TestService {
     "service-endpoints",
     "strongly-typed",
     "tags",
+    "server-side-polling"
   };
 
   static final Gson gson = new GsonBuilder().serializeNulls().create();

lib/sdk/server/contract-tests/test-suppressions-fdv2.txt

@@ -0,0 +1,3 @@
+streaming/fdv2/recoverable fallback to secondary synchronizer
+streaming/fdv2/recoverable fallback with recovery
+streaming/fdv2/permanent fallback with recovery