File data source shouldPersist tests.

Author: kinyoklion

lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/FileDataSourceBuilder.java

@@ -34,7 +34,7 @@ public final class FileDataSourceBuilder implements ComponentConfigurer<DataSour
   private boolean autoUpdate = false;
   private FileData.DuplicateKeysHandling duplicateKeysHandling = FileData.DuplicateKeysHandling.FAIL;
 
-  private boolean shouldPersist = false;
+  private boolean shouldPersist = true;
 
   /**
    * Adds any number of source files for loading flag data, specifying each file path as a string. The files will

lib/sdk/server/src/test/java/com/launchdarkly/sdk/server/integrations/FileDataSourceTest.java

@@ -31,6 +31,7 @@
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.equalTo;
 import static org.hamcrest.Matchers.is;
+import static org.hamcrest.Matchers.notNullValue;
 import static org.junit.Assert.assertEquals;
 
 @SuppressWarnings("javadoc")
@@ -160,10 +161,60 @@ public void instantiationOfArbitraryTypeIsNotAllowed() throws Exception {
       }
     }
   }
-  
+
+  @Test
+  public void dataSourceDefaultsToPersisting() throws Exception {
+    FileDataSourceBuilder factory = makeFactoryWithFile(resourceFilePath("all-properties.json"));
+    try (DataSource fp = makeDataSource(factory)) {
+      fp.start();
+
+      // Wait for and get the init data
+      com.launchdarkly.sdk.server.subsystems.DataStoreTypes.FullDataSet<com.launchdarkly.sdk.server.subsystems.DataStoreTypes.ItemDescriptor> initData =
+          dataSourceUpdates.receivedInits.poll(5, java.util.concurrent.TimeUnit.SECONDS);
+
+      assertThat(initData, notNullValue());
+      // The FullDataSet should have shouldPersist=true by default for legacy compatibility
+      assertThat(initData.shouldPersist(), equalTo(true));
+    }
+  }
+
+  @Test
+  public void dataSourceCanBeConfiguredToPersist() throws Exception {
+    FileDataSourceBuilder factory = FileData.dataSource()
+      .filePaths(resourceFilePath("all-properties.json"))
+      .shouldPersist(true);
+    try (DataSource fp = makeDataSource(factory)) {
+      fp.start();
+
+      // Wait for and get the init data
+      com.launchdarkly.sdk.server.subsystems.DataStoreTypes.FullDataSet<com.launchdarkly.sdk.server.subsystems.DataStoreTypes.ItemDescriptor> initData =
+          dataSourceUpdates.receivedInits.poll(5, java.util.concurrent.TimeUnit.SECONDS);
+
+      assertThat(initData, notNullValue());
+      assertThat(initData.shouldPersist(), equalTo(true));
+    }
+  }
+
+  @Test
+  public void dataSourceCanBeConfiguredToNotPersist() throws Exception {
+    FileDataSourceBuilder factory = FileData.dataSource()
+      .filePaths(resourceFilePath("all-properties.json"))
+      .shouldPersist(false);
+    try (DataSource fp = makeDataSource(factory)) {
+      fp.start();
+
+      // Wait for and get the init data
+      com.launchdarkly.sdk.server.subsystems.DataStoreTypes.FullDataSet<com.launchdarkly.sdk.server.subsystems.DataStoreTypes.ItemDescriptor> initData =
+          dataSourceUpdates.receivedInits.poll(5, java.util.concurrent.TimeUnit.SECONDS);
+
+      assertThat(initData, notNullValue());
+      assertThat(initData.shouldPersist(), equalTo(false));
+    }
+  }
+
   public static class SimulatedMaliciousType {
     static volatile boolean wasInstantiated = false;
-    
+
     public SimulatedMaliciousType(String value) {
       wasInstantiated = true;
     }

lib/sdk/server/src/test/java/com/launchdarkly/sdk/server/integrations/FileInitializerTest.java

@@ -100,6 +100,50 @@ public void initializerRespectsIgnoreDuplicateKeysHandling() throws Exception {
         }
     }
 
+    @Test
+    public void initializerDefaultsToNotPersisting() throws Exception {
+
+        try (Initializer initializer = FileData.initializer()
+            .filePaths(resourceFilePath("all-properties.json"))
+            .build(TestDataSourceBuildInputs.create(testLogger))) {
+            CompletableFuture<FDv2SourceResult> resultFuture = initializer.run();
+            FDv2SourceResult result = resultFuture.get(5, TimeUnit.SECONDS);
+
+            assertThat(result.getResultType(), equalTo(FDv2SourceResult.ResultType.CHANGE_SET));
+            assertThat(result.getChangeSet().shouldPersist(), equalTo(false));
+        }
+    }
+
+    @Test
+    public void initializerCanBeConfiguredToPersist() throws Exception {
+
+        try (Initializer initializer = FileData.initializer()
+            .filePaths(resourceFilePath("all-properties.json"))
+            .shouldPersist(true)
+            .build(TestDataSourceBuildInputs.create(testLogger))) {
+            CompletableFuture<FDv2SourceResult> resultFuture = initializer.run();
+            FDv2SourceResult result = resultFuture.get(5, TimeUnit.SECONDS);
+
+            assertThat(result.getResultType(), equalTo(FDv2SourceResult.ResultType.CHANGE_SET));
+            assertThat(result.getChangeSet().shouldPersist(), equalTo(true));
+        }
+    }
+
+    @Test
+    public void initializerCanBeConfiguredToNotPersist() throws Exception {
+
+        try (Initializer initializer = FileData.initializer()
+            .filePaths(resourceFilePath("all-properties.json"))
+            .shouldPersist(false)
+            .build(TestDataSourceBuildInputs.create(testLogger))) {
+            CompletableFuture<FDv2SourceResult> resultFuture = initializer.run();
+            FDv2SourceResult result = resultFuture.get(5, TimeUnit.SECONDS);
+
+            assertThat(result.getResultType(), equalTo(FDv2SourceResult.ResultType.CHANGE_SET));
+            assertThat(result.getChangeSet().shouldPersist(), equalTo(false));
+        }
+    }
+
     @Test
     public void initializerFailsOnDuplicateKeysByDefault() throws Exception {
 

lib/sdk/server/src/test/java/com/launchdarkly/sdk/server/integrations/FileSynchronizerTest.java

@@ -159,4 +159,48 @@ public void synchronizerAutoUpdateEmitsNewResultOnFileChange() throws Exception
             }
         }
     }
+
+    @Test
+    public void synchronizerDefaultsToNotPersisting() throws Exception {
+
+        try (Synchronizer synchronizer = FileData.synchronizer()
+            .filePaths(resourceFilePath("all-properties.json"))
+            .build(TestDataSourceBuildInputs.create(testLogger))) {
+            CompletableFuture<FDv2SourceResult> resultFuture = synchronizer.next();
+            FDv2SourceResult result = resultFuture.get(5, TimeUnit.SECONDS);
+
+            assertThat(result.getResultType(), equalTo(FDv2SourceResult.ResultType.CHANGE_SET));
+            assertThat(result.getChangeSet().shouldPersist(), equalTo(false));
+        }
+    }
+
+    @Test
+    public void synchronizerCanBeConfiguredToPersist() throws Exception {
+
+        try (Synchronizer synchronizer = FileData.synchronizer()
+            .filePaths(resourceFilePath("all-properties.json"))
+            .shouldPersist(true)
+            .build(TestDataSourceBuildInputs.create(testLogger))) {
+            CompletableFuture<FDv2SourceResult> resultFuture = synchronizer.next();
+            FDv2SourceResult result = resultFuture.get(5, TimeUnit.SECONDS);
+
+            assertThat(result.getResultType(), equalTo(FDv2SourceResult.ResultType.CHANGE_SET));
+            assertThat(result.getChangeSet().shouldPersist(), equalTo(true));
+        }
+    }
+
+    @Test
+    public void synchronizerCanBeConfiguredToNotPersist() throws Exception {
+
+        try (Synchronizer synchronizer = FileData.synchronizer()
+            .filePaths(resourceFilePath("all-properties.json"))
+            .shouldPersist(false)
+            .build(TestDataSourceBuildInputs.create(testLogger))) {
+            CompletableFuture<FDv2SourceResult> resultFuture = synchronizer.next();
+            FDv2SourceResult result = resultFuture.get(5, TimeUnit.SECONDS);
+
+            assertThat(result.getResultType(), equalTo(FDv2SourceResult.ResultType.CHANGE_SET));
+            assertThat(result.getChangeSet().shouldPersist(), equalTo(false));
+        }
+    }
 }