Use correct exit status on failure

[hadley]

e.g.:

adv-r (master): s3_website push --headless
ERROR: s3_website push was called with arguments ["--headless"]
Usage: "s3_website push".
adv-r (master): echo $?
0

Should be non-zero to indicate failure. This made me believe that s3_website was cheerfully working for weeks when in fact it was just failing silently :(

[laurilehmijoki]

Hi and thanks for reporting this bug. You are absolutely right. The exit status should be non-zero in your case.

I've fixed this problem in the version 2.1.12. Here is the commit: 60b3cf8.

The bug was caused by an unexpected behaviour in Thor. For more discussion on this unexpected exit status, see rails/thor#244.

As a side note, if you have been using the version 1 of s3_website, please read the release note on the version 2. The --headless switch no longer exists in that version. There are other backward incompatible changes as well.

[laurilehmijoki]

If you want to continue using the v1 of s3_website, just specify ~> 1 in your Gemfile.

In general, it is a good practice to specify the major version number of a semantically versioned tool. s3_website is semantically versioned.