[Fix Documentation] update the CONTRIBUTING.md with Issues & Pull Requests sectionsd Issues & Pull Requests, Reviewing Pull Requests #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the CONTRIBUTING.md by adding an Issues & Pull Requests, Reviewing Pull Requests section Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
sandramsc
changed the title
|
|
||
|
|
||
| 1. Search existing Issues before creating a new Issue (look to see if the Issue has already been created). | ||
| 1. If it doesn't exist create a new Issue giving as much context as possible (please take note and select the correct Issue type, for example `bug`, `documentation` or `feature`. |
There was a problem hiding this comment.
Please rephrase by removing the repeated words such as search, see, look.
It would be great if words like issue , pull requests to be in lowercase when they are not at start of the sentence.
goldfishdolphin
suggested changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #338
Notes for Reviewers
Signed commits