Update A records with changes, rather than overwriting them #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rkd-msw ah, I didn't notice this PR until just now. thanks for the contribution. I need to look deeper into why the CI tests are failing, it looks like the format has changed from what its expecting. I'll set aside some time this evening to pull and review. Again, sorry about the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3 - I've tested it live.
This change doesn't make it possible for clients to choose whether they should overwrite or update a record - partly because I wasn't sure what a sensible API would be, and partly to be consistent with AAAA records (where changes always trigger an update).
Do you think offering this choice is necessary (or will it just be irrelevant once #8 is fixed, and deleted nodes remove themselves)? If you do, what do you think the API should be?