Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crowdin Project Does Not Allow The Translations Without Variables Identical To The Original Text To Be Saved #10523

Open
5 tasks done
USS-Corvan opened this issue Dec 10, 2024 · 4 comments
Labels
Bug Gotta squash 'em all!

Comments

@USS-Corvan
Copy link

Is there an existing issue for this?

  • I have searched the existing issues.

Are you using the latest MineColonies Version?

  • I am running the latest beta/release version of MineColonies for my Minecraft version.
    I am also running the latest versions of other mods that are part of my problem.

Did you check on the Wiki? or ask on Discord?

  • I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

  • Single Player
  • Multi Player

Minecraft Version

1.21

MineColonies Version

1.1.820-1.21.1-snapshot

Structurize Version

1.0.758-1.21.1-snapshot

Related Mods and their Versions

1.NeoForge21.1.84 2.blockui-1.0.192-1.21.1-snapshot 3.domum_ornamentum-1.0.204-1.21.1-snapshot

Current Behavior

Crowdin project for this mod doesn't allow me to save translation due to the variables in the text being not identical to the original text. This could disrupt the grammar of non-English language such as Simp Chinese, as the order of words in a sentence could be different, thus causing trouble and prevent accurate translations.
image

Expected Behavior

image

Reproduction Steps

1.Go to the crowdin project of this mod.
2.Find a sentence with %s in it.
3.Use %2$s and %1$s to change the location of two the %s.

Logs

None

Anything else?

The specific string I encountered the problem: https://crowdin.com/editor/minecolonies/65/en-zhcn#80780

Footer


Viewers

  • Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
  • Add a comment if you have any insights or background information that isn't already part of the conversation.
@USS-Corvan USS-Corvan added the Bug Gotta squash 'em all! label Dec 10, 2024
@uecasm
Copy link
Contributor

uecasm commented Dec 10, 2024

This sounds more like a bug in CrowdIn itself; if they're going to perform that sort of validation then they should understand that it's legal to replace implicitly positioned placeholders with explicit ones. Have you reported it to them?

@USS-Corvan
Copy link
Author

This sounds more like a bug in CrowdIn itself; if they're going to perform that sort of validation then they should understand that it's legal to replace implicitly positioned placeholders with explicit ones. Have you reported it to them?

Not yet. Because in another project I participated in, there is no such problem (the screenshot in "expected behavior" coms from that project). I suspect there being a switch in the project setting that controls such behavior.

@Nightenom
Copy link
Member

Nightenom commented Dec 10, 2024

There are settings to manage variables in crowdin, I'm not sure what kind of format you're using, but I even haven't found the {3 | lower} format that is supported by forge back then

@USS-Corvan USS-Corvan changed the title Crowdin Project Does Not Allow The Use Of %1$s and %2$s Crowdin Project Does Not Allow The Translations Without Variables Identical To The Original Text To Be Saved Dec 11, 2024
@USS-Corvan
Copy link
Author

There are settings to manage variables in crowdin, I'm not sure what kind of format you're using, but I even haven't found the {3 | lower} format that is supported by forge back then

I apologize if I didn't make it clear. But my point is actually that I can't save the translation "due to the variables in the text being not identical to the original text", not the format I'm using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Gotta squash 'em all!
Projects
None yet
Development

No branches or pull requests

3 participants