Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace Batteries.HashMap with a shim around Std.HashMap #1063

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

chore: replace Batteries.HashMap with a shim around Std.HashMap #1063

wants to merge 9 commits into from
+39 −681

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Nov 24, 2024

No description provided.

@github-actions github-actions bot added the WIP work in progress label Nov 24, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 24, 2024
@leanprover-community-mathlib4-bot
Update Batteries branch for testing leanprover-community/batteries#1063
15046cf
@kim-em kim-em marked this pull request as ready for review November 24, 2024 03:09
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Nov 24, 2024 •
edited
Loading

Mathlib CI status (docs):

leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 24, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover-community/batteries#1063
4285834
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 25, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover-community/batteries#1063
06f078f
TwoFX
TwoFX reviewed Nov 25, 2024
View reviewed changes
Batteries/Data/HashMap/Basic.lean Show resolved Hide resolved
Batteries/Data/HashMap/Basic.lean Outdated Show resolved Hide resolved
Batteries/Data/HashMap/Basic.lean Outdated Show resolved Hide resolved
Batteries/Data/HashMap/Basic.lean Outdated Show resolved Hide resolved
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 25, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover-community/batteries#1063
7a447d0
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Dec 2, 2024
@kim-em kim-em removed WIP work in progress merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. labels Dec 3, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 3, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover-community/batteries#1063
eec010f
@fgdorais fgdorais added the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Dec 6, 2024
@fgdorais fgdorais requested a review from digama0 December 12, 2024 13:20
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Jan 4, 2025
@kim-em
Copy link
Collaborator Author

kim-em commented Jan 8, 2025

We've decided to wait on this until some further verification lemmas have been written for Std.HashMap. These are now being actively worked on, so hopefully it won't be too long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwoFX TwoFX TwoFX left review comments

@digama0 digama0 Awaiting requested review from digama0

Assignees
No one assigned
Labels
awaiting-review This PR is ready for review; the author thinks it is ready to be merged. builds-mathlib merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kim-em @leanprover-community-bot @digama0 @TwoFX @fgdorais @leanprover-community-mathlib4-bot