You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
There are a lot of lemmas with [prime p] typeclass argument which are actually only need something like p \ne 1. Perhaps some of these are useful, but they could be named more consistently.
Perhaps we could do a better job of ordering lemmas, I think there are several padic_val_nat sections.
As I think Michael Stoll suggested, it may be better to put the definition of padic_val_int before padic_val_nat.
There are still probably things that can be done to improve the
number_theory/padic_norm.lean
. Some ideas:padic_norm
with that latter part being calledpadic_norm.lean
and the first part beingpadic_val.lean
. See [Merged by Bors] - refactor(number_theory/padics/padic_norm): split file #13576[prime p]
typeclass argument which are actually only need something likep \ne 1
. Perhaps some of these are useful, but they could be named more consistently.padic_val_int
beforepadic_val_nat
.Originally posted by @BoltonBailey in #12454 (comment)
The text was updated successfully, but these errors were encountered: