Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

expand_exists improvements #15723

Open
robertylewis opened this issue Jul 27, 2022 · 1 comment · May be fixed by #15732
Open

expand_exists improvements #15723

robertylewis opened this issue Jul 27, 2022 · 1 comment · May be fixed by #15732
Labels
t-meta Tactics, attributes or user commands

Comments

@robertylewis
Copy link
Member

robertylewis commented Jul 27, 2022

Reported by @RemyDegenne on Zulip:

I am testing the new expand_exists attribute, which looks like a very useful tool, and I have two remarks/questions:

  • The names given to the new lemmas are interpreted as being names in the _root_ namespace. For example, if I have the namespace measure_theory open and use [expand_exists def_name] I do not get measure_theory.def_name, but _root_.def_name. I expected the opposite behaviour. Is it an intentional design decision?
  • The attribute creates a def and lemmas, but the def does not have a docstring and the linter complains. Is there a way to give a dosctring when using the attribute?
  • Namespacing the new declarations can be done mimicking the logic of to_additive.
  • Doc strings can also be taken with approximately the syntax of to_additive. This is a little ugly/tricky to parse, so as a stopgap (or permanently, alongside this solution), we should mention add_decl_doc in the doc string for expand_exists.

@0x182d4454fb211940 are you interested in taking on these feature requests?

@robertylewis robertylewis added the t-meta Tactics, attributes or user commands label Jul 27, 2022
@0x182d4454fb211940
Copy link
Collaborator

Yeah I'll be happy to work on this. I'll start when I have some free time (likely tomorrow).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
t-meta Tactics, attributes or user commands
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants