Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BitVec.ult/ule_ofNat #3452

Closed
wants to merge 1 commit into from
Closed

Conversation

bollu
Copy link
Contributor

@bollu bollu commented Feb 22, 2024

This supersedes leanprover-community/batteries#664, and adds lemmas that mirror ofNat_{add,sub}_ofNat for ult, ule.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Feb 22, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase b6ed97bb3dad824d3c1fc82dbf290ef0505c42d0 --onto 6719af350fde9339354f28d091458df39a4af9d4. (2024-02-22 02:08:35)

@bollu
Copy link
Contributor Author

bollu commented Feb 24, 2024

awaiting-review

@github-actions github-actions bot added the awaiting-review Waiting for someone to review the PR label Feb 24, 2024
@joehendrix
Copy link
Contributor

I don't think either of these should be simp rules. There is active work on integrating SAT solving into Lean, and in the ground case, I think it'd be useful to keep the Bitvec types around.

@joehendrix joehendrix added awaiting-author Waiting for PR author to address issues and removed awaiting-review Waiting for someone to review the PR labels Feb 28, 2024
@github-actions github-actions bot added the stale label May 5, 2024
@kim-em kim-em self-requested a review as a code owner May 29, 2024 16:23
@github-actions github-actions bot removed the stale label May 30, 2024
@bollu
Copy link
Contributor Author

bollu commented Jun 6, 2024

They're no longer simp lemmas.

@bollu
Copy link
Contributor Author

bollu commented Jun 6, 2024

awaiting-review

@github-actions github-actions bot added awaiting-review Waiting for someone to review the PR and removed awaiting-author Waiting for PR author to address issues labels Jun 6, 2024
@Kha
Copy link
Member

Kha commented Sep 12, 2024

@bollu @semorrison Is this still desirable?

@leanprover-bot leanprover-bot added the P-medium We may work on this issue if we find the time label Sep 13, 2024
@kim-em kim-em closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review Waiting for someone to review the PR P-medium We may work on this issue if we find the time toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants