Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: wrap diagnostic results in MessageData.traces #4897

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

mattrobball
Copy link
Contributor

@mattrobball mattrobball commented Aug 1, 2024

Currently, the messages in the diagnostic summaries are created by appending interpolated strings. We wrap these in .trace's, and the results are better formatted when expanding child nodes in the info view. Particularly, the latter diagnostic summaries remain on their own lines flush to the left instead of on the same line directly adjacent to the last child node.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 1, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries CI can not be attempted yet, as the nightly-testing-2024-08-01 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Batteries CI should run now. (2024-08-01 15:16:57)

@leodemoura leodemoura marked this pull request as ready for review August 5, 2024 23:29
@leodemoura leodemoura self-requested a review as a code owner August 5, 2024 23:29
@leodemoura leodemoura added this pull request to the merge queue Aug 5, 2024
@leodemoura leodemoura removed this pull request from the merge queue due to a manual request Aug 5, 2024
@leodemoura
Copy link
Member

@mattrobball The new output looks good to me. Ready to merge?

@mattrobball
Copy link
Contributor Author

Yes, thanks.

@leodemoura leodemoura added this pull request to the merge queue Aug 6, 2024
Merged via the queue into leanprover:master with commit 7bea3c1 Aug 6, 2024
13 checks passed
@mattrobball mattrobball deleted the mrb/diag_line_breaks branch August 7, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants