trace.profiler.threshold is too coarse

[eric-wieser]

Prerequisites

Please put an X between the brackets as you perform the following steps:

• Check that your issue is not already filed:
  https://github.com/leanprover/lean4/issues
• Reduce the issue to a minimal, self-contained, reproducible test case.
  Avoid dependencies to Mathlib or Batteries.
• Test your test case against the latest nightly release, for example on
  https://live.lean-lang.org/#project=lean-nightly
  (You can also use the settings there to switch to “Lean nightly”)

Description

set_option trace.profiler.threshold is very helpful for filtering profiles, but 1ms of resolution is too coarse; using a value of 1 doesn't capture enough data, and using a value of 0 captures way too much.

Context

@hrmacbeth, @robertylewis and I are trying to profile and speedup linarith; with a threshold of 1 we miss most of the cost paid by thousands of calls to MetaM.mkAppM, while with a threshold of 0 the recorded data is too large and never finishes writing out to the profile file.

Steps to Reproduce

Run

set_option trace.profiler.threshold 0.0001
set_option trace.profiler.threshold 100ns

Expected behavior: One of the above should be legal

Actual behavior: Neither is valid syntax, as lean options cannot hold durations or ofScientific literals

Versions

4.14.0

Additional Information

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.