-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: mark Mul.mul and HMul.hMul as match_pattern #6863
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
label
Jan 30, 2025
Mathlib CI status (docs):
|
An overview of places where this could be used in mathlib:
|
allows fixing regressions in mathlib introduced in nightly-2024-02-25
jcommelin
force-pushed
the
jmc-match-pattern-mul
branch
from
January 30, 2025 18:28
49e3bf5
to
a1e2f67
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 30, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 30, 2025
leanprover-community-bot
added
the
builds-mathlib
CI has verified that Mathlib builds against this PR
label
Jan 30, 2025
leanprover-community-bot
added
breaks-mathlib
This is not necessarily a blocker for merging: but there needs to be a plan
and removed
builds-mathlib
CI has verified that Mathlib builds against this PR
labels
Jan 30, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 30, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 30, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 30, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 30, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 31, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 31, 2025
kim-em
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 2, 2025
* fixes * fixes * chore: bump to nightly-2025-01-15 * fix * empty commit to bump CI * Update lean-toolchain for testing leanprover/lean4#6660 * fixes for leanprover/lean4#6660 * chore: bump to nightly-2025-01-16 * . * fix * chore: bump to nightly-2025-01-17 * deprecation * chore: bump to nightly-2025-01-18 * Merge master into nightly-testing * chore: bump to nightly-2025-01-19 * fix * chore: bump to nightly-2025-01-20 * fix and bump * bump ProofWidgets * chore: bump to nightly-2025-01-21 * bump * Adaptations * fixes * fix * fix * chore: bump to nightly-2025-01-22 * chore: adaptations for nightly-2025-01-22 * remove deprecation for List.indexOf_lt_length * chore: bump to nightly-2025-01-23 * chore: bump to nightly-2025-01-24 * Adjust expected output in MathlibTest.CountHeartbeats * chore: adaptations for nightly-2025-01-24 * chore: bump to nightly-2025-01-25 * chore: bump to nightly-2025-01-26 * chore: bump to nightly-2025-01-27 * Merge master into nightly-testing * Adaption for leanprover/lean4#6755 * Update lean-toolchain for testing leanprover/lean4#6800 * lake update for leanprover/lean4#6800 * Trigger CI for leanprover/lean4#6800 * fixes for leanprover/lean4#6800 * Trigger CI for leanprover/lean4#6800 * fix * Update lean-toolchain for testing leanprover/lean4#6812 * chore: bump to nightly-2025-01-28 * lake update for leanprover/lean4#6812 * TrivSqZeroExt.snd_list_prod fix * Update lean-toolchain for testing leanprover/lean4#6826 * Adaption * fix * fix * remove deprecation/alias * touch for CI for leanprover/lean4#6812 * fix for leanprover/lean4#6812 * Trigger CI for leanprover/lean4#6826 * chore: bump to nightly-2025-01-29 * . * merge lean-pr-testing-6812 * . * lake update * lake update * fixes and deprecations * name clash * fix * fix * update * lint * shake * fix(#count_heartbeats): add `approximately` flag to stabilise tests * chore: bump to nightly-2025-01-30 * add option also to the linter * use sleep_heartbeats in test * update * deprecation * don't count heartbeats * Update lean-toolchain for testing leanprover/lean4#6863 * use 'x * y' as match pattern * Trigger CI for leanprover/lean4#6863 * Trigger CI for leanprover/lean4#6863 * Trigger CI for leanprover/lean4#6863 * wip * Trigger Build * chore: bump to nightly-2025-01-31 * update * fix * chore: bump to nightly-2025-02-01 * chore: bump to nightly-2025-02-02 --------- Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com> Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: Joachim Breitner <mail@joachim-breitner.de> Co-authored-by: Yakov Pechersky <ffxen158@gmail.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: adomani <adomani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaks-mathlib
This is not necessarily a blocker for merging: but there needs to be a plan
changelog-library
Library
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows fixing regressions in mathlib introduced in nightly-2024-02-25 by allowing the use of
x * y
in match patterns. There are currently 11 instances in mathlib explicitly flagging the lack of this match pattern.This issue was previously pointed out in the following Zulip threads: