You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When there is enough space, KSelect's dropdown should be displayed below the input. However, there are several places in Kolibri where the dropdown is displayed above the input, even though there's enough space below. One example from Kolibri 0.17.0a0.dev0+git.123.g5cd1f6aa:
Coach → Plan → Lessons
This issue is present in other selects in Plan and Reports.
Interestingly, in a very similar place in Facility → Users, it works as expected:
The main culprit seems to be the bottom positioning set to 62px on .ui-select-dropdown. After commenting it out, the dropdown shows correctly in the Coach:
The bottom value is calculated in the calculateSpaceBelow method:
The goal of this issue is to find out why exactly the calculation doesn't work well for places in the Coach (or check whether it’s overwritten from somewhere else, even though that’s rather unlikely). After we know more, we can determine the next steps and see if the calculation can be optimized.
References
Originally reported in learningequality/kolibri#12079 (not related to the refactor being tested there - the bug was present before).
The text was updated successfully, but these errors were encountered:
Hey @MisRob I was planning to work on this issue , so I was trying to reproduce the 1st img coach->plan->lesson but when I signed up in Kolibri I was signed up as a learner, could you please help me here. 😓
Hi @Sahil-Sinha-11 this could be that you are signing in with a learner account you created instead. You need to create a admin or coach account and log in
@Sahil-Sinha-11 When setting up Kolibri, you created admin account in the setup wizard I assume? Can you use the admin account to login? That should make this place accessible.
🌱 Are you new to the codebase? Welcome! Please see the contributing guidelines.
Summary
When there is enough space,
KSelect
's dropdown should be displayed below the input. However, there are several places in Kolibri where the dropdown is displayed above the input, even though there's enough space below. One example from Kolibri 0.17.0a0.dev0+git.123.g5cd1f6aa:Coach → Plan → Lessons
This issue is present in other selects in Plan and Reports.
Interestingly, in a very similar place in Facility → Users, it works as expected:
The main culprit seems to be the
bottom
positioning set to62px
on.ui-select-dropdown
. After commenting it out, the dropdown shows correctly in the Coach:The
bottom
value is calculated in thecalculateSpaceBelow
method:kolibri-design-system/lib/KSelect/index.vue
Lines 878 to 893 in 0cbdf57
The goal of this issue is to find out why exactly the calculation doesn't work well for places in the Coach (or check whether it’s overwritten from somewhere else, even though that’s rather unlikely). After we know more, we can determine the next steps and see if the calculation can be optimized.
References
Originally reported in learningequality/kolibri#12079 (not related to the refactor being tested there - the bug was present before).
The text was updated successfully, but these errors were encountered: