Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KCard: Allow the height of sections to be configured and related improvements #703

Closed
MisRob opened this issue Jul 27, 2024 · 1 comment · Fixed by #785
Closed

KCard: Allow the height of sections to be configured and related improvements #703

MisRob opened this issue Jul 27, 2024 · 1 comment · Fixed by #785
Assignees
Labels
category: library Shared code library Component: KCard P1 - important Priority: High impact on UX

Comments

@MisRob
Copy link
Member

MisRob commented Jul 27, 2024

Current behavior

In the first version of KCard, its sections (above title, footer, ...) have fixed height and the card itself has fixed height as well. This is to provide reasonable behavior in regard to consistent sections alignment in a grid row.

Expected behavior

While above still true, KCard needs to be a bit more intelligent to support our many use-cases.

  1. Sections' default fixed height can be easily overwritten by consumers
  2. To support above, the card's overall height needs to be calculated as a sum total of its sections heights

Ideally, public API to achieve this would be as close as possible to native experience, and would also work with 'auto' height settings that would let sections to take full height of their content (in a grid, this would result in a row being as high as the highest card)

@MisRob MisRob self-assigned this Jul 27, 2024
@MisRob MisRob added P1 - important Priority: High impact on UX Component: KCard category: library Shared code library labels Jul 27, 2024
@MisRob
Copy link
Member Author

MisRob commented Jul 27, 2024

Related #697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment