Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update KDS Theme Token values #775

Closed
marcellamaki opened this issue Sep 10, 2024 — with Slack · 1 comment · Fixed by #782
Closed

Update KDS Theme Token values #775

marcellamaki opened this issue Sep 10, 2024 — with Slack · 1 comment · Fixed by #782
Assignees
@AlexVelezLl
Labels
P0 - critical Priority: Release blocker or regression
Milestone
KDS Priority Triage

Comments

@marcellamaki Slack
Copy link
Member

marcellamaki commented Sep 10, 2024 •
edited
Loading

When upgrading our themes for the rebrand, the new numerical token values for colors did not correspond exactly to the material specifications. This is fine in main Kolibri, but presents a challenge for upgrading custom themed Kolibri.

While we will need to make these changes in some places in Kolibri as well, the first thing will be to make the changes in KDS.

The updated mapping:
Screenshot 2024-09-06 at 12 14 29 PM
@marcellamaki marcellamaki added the P0 - critical Priority: Release blocker or regression label Sep 10, 2024 — with Slack
@marcellamaki marcellamaki added this to the KDS Priority Triage milestone Sep 10, 2024 — with Slack
@AlexVelezLl AlexVelezLl mentioned this issue Sep 16, 2024
Merged
8 tasks
@AlexVelezLl AlexVelezLl linked a pull request Sep 24, 2024 that will close this issue
Update KDS Theme Tokens #782
Merged
8 tasks
@AlexVelezLl
Copy link
Member

Closed by #782

@AlexVelezLl AlexVelezLl mentioned this issue Oct 21, 2024
Merged
8 tasks
@marcellamaki marcellamaki mentioned this issue Oct 22, 2024
Closed
@AlexVelezLl AlexVelezLl mentioned this issue Oct 24, 2024
Merged
9 tasks
@rtibbles rtibbles mentioned this issue Oct 29, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexVelezLl AlexVelezLl

Labels
P0 - critical Priority: Release blocker or regression
Projects
None yet
Milestone
KDS Priority Triage
Development

Successfully merging a pull request may close this issue.

Update KDS Theme Tokens AlexVelezLl/kolibri-design-system
2 participants
@marcellamaki @AlexVelezLl