Skip to content

Commit 8283bb9

Browse files
[pre-commit.ci lite] apply automatic fixes
1 parent 04eca3b commit 8283bb9

File tree

10 files changed

+77
-92
lines changed

10 files changed

+77
-92
lines changed

kolibri/plugins/facility/assets/src/composables/useActionWithUndo.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
import { computed } from 'vue';
22
import { coreStrings } from 'kolibri/uiText/commonCoreStrings';
33
import useSnackbar from 'kolibri/composables/useSnackbar';
4-
import {
5-
bulkUserManagementStrings
6-
} from 'kolibri-common/strings/bulkUserManagementStrings';
4+
import { bulkUserManagementStrings } from 'kolibri-common/strings/bulkUserManagementStrings';
75

86
/**
97
*

kolibri/plugins/facility/assets/src/composables/useUserManagement.js

Lines changed: 22 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -38,22 +38,22 @@ export default function useUserManagement({
3838
dataLoading.value = true;
3939
try {
4040
const fetchResource = softDeletedUsers ? DeletedFacilityUserResource : FacilityUserResource;
41-
const getParams = Boolean(by_ids.value) ?
42-
{
43-
by_ids: by_ids.value,
44-
member_of: activeFacilityId,
45-
page: page.value,
46-
page_size: pageSize.value,
47-
} :
48-
pickBy({
49-
member_of: activeFacilityId,
50-
date_joined__gte: dateJoinedGt?.toISOString(),
51-
page: page.value,
52-
page_size: pageSize.value,
53-
search: search.value?.trim() || null,
54-
ordering: order.value === 'desc' ? `-${ordering.value}` : ordering.value || null,
55-
...getBackendFilters(),
56-
});
41+
const getParams = by_ids.value
42+
? {
43+
by_ids: by_ids.value,
44+
member_of: activeFacilityId,
45+
page: page.value,
46+
page_size: pageSize.value,
47+
}
48+
: pickBy({
49+
member_of: activeFacilityId,
50+
date_joined__gte: dateJoinedGt?.toISOString(),
51+
page: page.value,
52+
page_size: pageSize.value,
53+
search: search.value?.trim() || null,
54+
ordering: order.value === 'desc' ? `-${ordering.value}` : ordering.value || null,
55+
...getBackendFilters(),
56+
});
5757

5858
const resp = await fetchResource.fetchCollection({
5959
getParams,
@@ -87,7 +87,12 @@ export default function useUserManagement({
8787
}
8888
};
8989

90-
function onChange({ resetSelection = false, affectedClasses = null, created = [], invalid = [] } = {}) {
90+
function onChange({
91+
resetSelection = false,
92+
affectedClasses = null,
93+
created = [],
94+
invalid = [],
95+
} = {}) {
9196
if (resetSelection) {
9297
selectedUsers.value = new Set();
9398
}

kolibri/plugins/facility/assets/src/composables/useUsersFilters.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ export default function useUsersFilters({ classes }) {
124124
watch(
125125
routeFilters,
126126
newFilters => {
127-
if(workingFilters.by_ids?.length) {
127+
if (workingFilters.by_ids?.length) {
128128
// If we're filtering by by_ids, it's programmatic navigation
129129
// so we will clear all existing filters and set the ids alone
130130
resetWorkingFilters();

kolibri/plugins/facility/assets/src/constants.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,9 @@ export const PageNames = {
2525
ENROLL_LEARNERS_SIDE_PANEL__NEW_USERS: 'ENROLL_LEARNERS_SIDE_PANEL__NEW_USERS',
2626
};
2727

28-
2928
export const InvalidActionTypes = {
30-
ASSIGN: "assign",
31-
ENROLL: "enroll",
29+
ASSIGN: 'assign',
30+
ENROLL: 'enroll',
3231
};
3332

3433
// modal names

kolibri/plugins/facility/assets/src/views/CoachClassAssignmentPage.vue

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@
2828
import ImmersivePage from 'kolibri/components/pages/ImmersivePage';
2929
import commonCoreStrings from 'kolibri/uiText/commonCoreStrings';
3030
import useSnackbar from 'kolibri/composables/useSnackbar';
31-
import ClassEnrollForm from './ClassEnrollForm';
3231
import { bulkUserManagementStrings } from 'kolibri-common/strings/bulkUserManagementStrings';
3332
import useActionWithUndo from '../composables/useActionWithUndo';
33+
import ClassEnrollForm from './ClassEnrollForm';
3434
3535
export default {
3636
name: 'CoachClassAssignmentPage',
@@ -46,11 +46,8 @@
4646
mixins: [commonCoreStrings],
4747
setup() {
4848
const { createSnackbar } = useSnackbar();
49-
const {
50-
someLearnersEnrolledNotice$,
51-
coachesAllAssignedNotice$,
52-
someCoachesAssignedNotice$,
53-
} = bulkUserManagementStrings;
49+
const { someLearnersEnrolledNotice$, coachesAllAssignedNotice$, someCoachesAssignedNotice$ } =
50+
bulkUserManagementStrings;
5451
return {
5552
someCoachesAssignedNotice$,
5653
coachesAllAssignedNotice$,
@@ -81,15 +78,14 @@
8178
this.assignCoachesToClass({ classId: this.class.id, coaches })
8279
.then(response => {
8380
const { created, invalid } = response.data;
84-
if(created?.length) {
85-
if(invalid?.length) {
81+
if (created?.length) {
82+
if (invalid?.length) {
8683
this.createSnackbar(this.someCoachesAssignedNotice$());
8784
} else {
8885
this.createSnackbar(this.coachesAllAssignedNotice$());
8986
}
9087
}
91-
this.$router
92-
.push(this.$store.getters.facilityPageLinks.ClassEditPage(this.class.id))
88+
this.$router.push(this.$store.getters.facilityPageLinks.ClassEditPage(this.class.id));
9389
})
9490
.catch(() => {
9591
this.formIsDisabled = false;

kolibri/plugins/facility/assets/src/views/LearnerClassEnrollmentPage.vue

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,7 @@
4545
mixins: [commonCoreStrings],
4646
setup() {
4747
const { createSnackbar } = useSnackbar();
48-
const {
49-
usersEnrolledNotice$,
50-
someLearnersEnrolledNotice$,
51-
} = bulkUserManagementStrings;
48+
const { usersEnrolledNotice$, someLearnersEnrolledNotice$ } = bulkUserManagementStrings;
5249
return {
5350
createSnackbar,
5451
usersEnrolledNotice$,
@@ -83,8 +80,8 @@
8380
this.enrollLearnersInClass({ classId: this.class.id, users: selectedUsers })
8481
.then(response => {
8582
const { created, invalid } = response.data;
86-
if(created?.length) {
87-
if(invalid?.length) {
83+
if (created?.length) {
84+
if (invalid?.length) {
8885
this.createSnackbar(this.someLearnersEnrolledNotice$());
8986
} else {
9087
this.createSnackbar(this.usersEnrolledNotice$());

kolibri/plugins/facility/assets/src/views/users/UsersRootPage/index.vue

Lines changed: 11 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,6 @@
9999
/>
100100
</template>
101101
<template #userActions>
102-
103102
<KIconButton
104103
ref="assignButton"
105104
icon="assignCoaches"
@@ -267,7 +266,6 @@
267266
someFailedToEnroll$,
268267
} = bulkUserManagementStrings;
269268
270-
271269
const { $store, $router } = getCurrentInstance().proxy;
272270
const activeFacilityId =
273271
$router.currentRoute.params.facility_id || $store.getters.activeFacilityId;
@@ -361,24 +359,19 @@
361359
});
362360
363361
const showingInvalidUsers = computed(() => {
364-
return (
365-
Boolean(route.query.by_ids) &&
366-
Boolean(route.query.failedActionType)
367-
);
362+
return Boolean(route.query.by_ids) && Boolean(route.query.failedActionType);
368363
});
369-
const warningMessage = computed(
370-
() => {
371-
switch(route.query?.failedActionType) {
372-
case(InvalidActionTypes.ASSIGN):
373-
return someFailedToAssign$();
374-
case(InvalidActionTypes.ENROLL):
375-
return someFailedToEnroll$();
376-
default:
377-
// When the page loads
378-
return '';
379-
}
364+
const warningMessage = computed(() => {
365+
switch (route.query?.failedActionType) {
366+
case InvalidActionTypes.ASSIGN:
367+
return someFailedToAssign$();
368+
case InvalidActionTypes.ENROLL:
369+
return someFailedToEnroll$();
370+
default:
371+
// When the page loads
372+
return '';
380373
}
381-
);
374+
});
382375
383376
return {
384377
warningMessage,

kolibri/plugins/facility/assets/src/views/users/sidePanels/AssignCoachesSidePanel.vue

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -239,18 +239,15 @@
239239
affectedClasses: selectedClasses.value,
240240
resetSelection: true,
241241
});
242-
if(invalidRoles.value.length) {
242+
if (invalidRoles.value.length) {
243243
router.push(
244-
overrideRoute(
245-
route,
246-
{
247-
name: getRootRouteName(route),
248-
query: {
249-
by_ids: invalidRoles.value.map(r => r.user).join(','),
250-
failedActionType: InvalidActionTypes.ASSIGN,
251-
},
244+
overrideRoute(route, {
245+
name: getRootRouteName(route),
246+
query: {
247+
by_ids: invalidRoles.value.map(r => r.user).join(','),
248+
failedActionType: InvalidActionTypes.ASSIGN,
252249
},
253-
)
250+
}),
254251
);
255252
return true;
256253
} else {
@@ -298,7 +295,7 @@
298295
invalidRoles.value = invalid || [];
299296
}
300297
301-
const canUndo = computed(() => createdRoles.value?.length)
298+
const canUndo = computed(() => createdRoles.value?.length);
302299
303300
async function handleUndoAssignments() {
304301
if (createdRoles.value?.length > 0) {
@@ -311,14 +308,14 @@
311308
}
312309
313310
const snackbarMessage$ = () => {
314-
if(createdRoles.value?.length) {
315-
if(invalidRoles.value?.length) {
311+
if (createdRoles.value?.length) {
312+
if (invalidRoles.value?.length) {
316313
return someCoachesAssignedNotice$();
317314
} else {
318315
return coachesAllAssignedNotice$();
319316
}
320317
}
321-
if(invalidRoles.value?.length) {
318+
if (invalidRoles.value?.length) {
322319
return someFailedToAssign$();
323320
}
324321
};

kolibri/plugins/facility/assets/src/views/users/sidePanels/EnrollLearnersSidePanel.vue

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -223,8 +223,7 @@
223223
async function _enrollLearners() {
224224
loading.value = true;
225225
const enrollments = selectedOptions.value.flatMap(collection_id => {
226-
return Array.from(props.selectedUsers)
227-
.map(user => ({ collection: collection_id, user }));
226+
return Array.from(props.selectedUsers).map(user => ({ collection: collection_id, user }));
228227
});
229228
if (enrollments.length > 0) {
230229
try {
@@ -243,18 +242,15 @@
243242
// so that the confirmation guard doesn't trigger in this case
244243
return nextTick(() => {
245244
// This doesn't need to be done in the assign side panel but IDK for sure why
246-
if(Boolean(invalid)) {
245+
if (invalid) {
247246
router.push(
248-
overrideRoute(
249-
route,
250-
{
251-
name: getRootRouteName(route),
252-
query: {
253-
by_ids: invalidMemberships.value.map(r => r.user).join(','),
254-
failedActionType: InvalidActionTypes.ENROLL,
255-
},
247+
overrideRoute(route, {
248+
name: getRootRouteName(route),
249+
query: {
250+
by_ids: invalidMemberships.value.map(r => r.user).join(','),
251+
failedActionType: InvalidActionTypes.ENROLL,
256252
},
257-
)
253+
}),
258254
);
259255
emit('clearSelection');
260256
return true;
@@ -282,19 +278,19 @@
282278
}
283279
284280
const snackbarMessage$ = () => {
285-
if(createdMemberships.value?.length) {
286-
if(invalidMemberships.value?.length) {
281+
if (createdMemberships.value?.length) {
282+
if (invalidMemberships.value?.length) {
287283
return someLearnersEnrolledNotice$();
288284
} else {
289285
return usersEnrolledNotice$();
290286
}
291287
}
292-
if(invalidMemberships.value?.length) {
288+
if (invalidMemberships.value?.length) {
293289
return someFailedToEnroll$();
294290
}
295291
};
296292
297-
const canUndo = computed(() => createdMemberships.value?.length)
293+
const canUndo = computed(() => createdMemberships.value?.length);
298294
299295
const { performAction: enrollLearners } = useActionWithUndo({
300296
action: _enrollLearners,

packages/kolibri-common/strings/bulkUserManagementStrings.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -205,19 +205,23 @@ export const bulkUserManagementStrings = createTranslator('BulkUserManagementStr
205205
},
206206
someLearnersEnrolledNotice: {
207207
message: 'Some learners enrolled succesfully, but some were not',
208-
context: 'Shown at the top of a table that is filtered to show the users which did not get assigned successfully',
208+
context:
209+
'Shown at the top of a table that is filtered to show the users which did not get assigned successfully',
209210
},
210211
someCoachesAssignedNotice: {
211212
message: 'Some coaches assigned succesfully, but some were not.',
212-
context: 'Shown at the top of a table that is filtered to show the users which did not get assigned successfully',
213+
context:
214+
'Shown at the top of a table that is filtered to show the users which did not get assigned successfully',
213215
},
214216
someFailedToAssign: {
215217
message: 'The users shown were unable to be assigned.',
216-
context: 'Shown at the top of a table that is filtered to show the users which did not get assigned successfully',
218+
context:
219+
'Shown at the top of a table that is filtered to show the users which did not get assigned successfully',
217220
},
218221
someFailedToEnroll: {
219222
message: 'The users shown were unable to be enrolled.',
220-
context: 'Shown at the top of a table that is filtered to show the users which did not get assigned successfully',
223+
context:
224+
'Shown at the top of a table that is filtered to show the users which did not get assigned successfully',
221225
},
222226
assignCoachUndoneNotice: {
223227
message: 'Assign action has been undone',

0 commit comments

Comments
 (0)