Facility > Users - Creating duplicate users by restoring deleted users

[pcenov]

❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.

Observed behavior

Reporting this as a separate issue as I think I had previously mentioned it somewhere as a comment but now I can't find it: If I remove a user so that the user becomes soft deleted and is kept only in the "Removed users" table and if I go ahead and create a brand new user with the same username, then I am able to restore the first user so that I will have 2 users with the same duplicate username.

Expected behavior

To be further specified.

Steps to reproduce the issue

1. Install the build from https://github.com/learningequality/kolibri/releases/tag/v0.19.0-beta0
2. Create one user and then soft delete that user
3. Create a new user with the same username
4. Restore the previously deleted user

Usage Details

Kolibri 0.19.0b0
Windows 11, Ubuntu 22, Mac OS 15.5 - Chrome, Firefox

[pcenov]

@radinamatic

[nucleogenesis]

@rtibbles I recall we talked about this and my memory is that we didn't want to go the way of making username unique or anything big like that. I think we discussed that this is a situation where we provide the tools to the user needed to fix the problem (ie, update the username of one of the unexpectedly duplicated usernames).

Does that jive with your memory and/or current thoughts on how we approach this? I've tried thinking through various scenarios where this could be catastrophic but I cannot think of any. I'm thinking this is a wontfix (or push to major release milestone) as I cannot think of any way to address this without additional strings - which might work well w/ the error/warning messaging we did in #13865 to just warn someone "yo you have 2 users with the same username 'jakethesnake', change one of them or else only 1 of those users will be able to access their account".

In any case - happy to chat about this further and look forward to your thoughts