Facility > Users - Any selected users remain selected even after having applied additional filters

[pcenov]

❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.

Observed behavior

A potentially confusing issue I noticed while testing #13865 but which is also extant in https://github.com/learningequality/kolibri/releases/tag/v0.19.0-beta1 is that if I select all the users and then apply a filter, all of the previously selected users remain selected.

selected.users.and.filters.mp4

Expected behavior

This should be further discussed and specified but I would expect that after applying any additional filters, the users for which the filters do not apply should no longer be selected so that I can perform the available assign, enroll, remove and delete operations only on the filtered users.

Steps to reproduce the issue

1. Install the build from https://github.com/learningequality/kolibri/releases/tag/v0.19.0-beta1
2. Go to Device > Users and select all of the available users.
3. Apply a filter and observe that the number of selected users remains the same.

Usage Details

Kolibri 0.19.0b1
Windows 11, Ubuntu 22, Mac OS 15.5 - Chrome, Firefox

[pcenov]

@radinamatic

[nucleogenesis]

I don't expect filters to change my selection on the table. Filters should only change what I see IMO - the same as how pagination or sorting shouldn't remove my selections, nor should filtering the visible items in the table.

There's a "Clear selection" button for any case where someone wants to start fresh that way - but if we wipe selections when filters change, then the user will lose their work and cannot use filters to incrementally put together a selection of users.

[marcellamaki]

I think that filtering is fundamentally different than pagination, and I would expect a filter to essentially be an "AND" operator, meaning that the previous selection plus the filter must be true. Or alternatively, to reset the selection and just apply the filter. (Option 2 - removing any current selection and applying the filter - is actually how both github and gmail handle this in bulk interactions). But I'm open to the fact that there might not be one obvious expected behavior here.

I think if we don't have enough of an internal consensus for default, then we can keep this as it is and validate it with a very focused/specific usertesting.com test, and retarget this to planned patch 1 based on the outcome of the results.

[AllanOXDi]

One thing am not sure of, should we reset selection even after search or it should only happen on filtering.

[pcenov]

Yes, because searching by a keyword is essentially additional filtering.