Fix/clipboard icons alignment #4923
Open
+101
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjester
requested changes
Feb 28, 2025
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
This seems like a mistake to add so many extra new lines?
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Yes noticed this after pushing will work on this soon.
bjester
reviewed
Feb 28, 2025
| @@ -148,12 +148,61 @@ | |||
|
|
|||
| </script> | |||
|
|
|||
| <!-- Remove "scoped" so that our override rules apply globally to KCheckbox internals --> | |||
| <style lang="less"> | |||
There was a problem hiding this comment.
We're no longer supporting LESS. SCSS or plain CSS only please
There was a problem hiding this comment.
Okay sure . Also , Any guidance on how to make sure code passes javascript cl tests , i am troubling with that a bit also?
There was a problem hiding this comment.
The error I saw in the tests in failing checks here on the PR seems related to this issue. Presumably, switching back to SCSS should help?
There was a problem hiding this comment.
Okay sure , will do the suggested changes. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed checkbox alignment issues in the UI that were causing misalignment between checkbox icons and their corresponding text labels. The checkboxes were appearing slightly misaligned with channel names and folder items in different views.
Modified checkbox.vue to improve alignment using a flexbox-based approach
Added a slight vertical offset to properly align checkbox icons with text
Standardized checkbox icon dimensions to ensure consistency
Manually verified on both channel and folder item views to ensure proper alignment
The fix addresses the inconsistent vertical positioning that was affecting UI appearance
#Before -->
#After -->
References
Addresses #4771
Reviewer guidance