fix(markdown) allow opening parsed url in same tab

Author: LorenzoBoffa

apps/storybook/stories/Markdown.stories.tsx

@@ -129,6 +129,8 @@ export const MarkdownOpenLinks = bind(
     </HorizontalStack>
     <HorizontalStack justifyContent='space-evenly'>
       <Markdown size='sm' opensInSameTabRegexes={[PLAYER_REGEX, COURSE_REGEX]} parseUrlsMethod={parseUrl} >[Modify link and open in same tab](learnn://player/7164/?t=14) </Markdown>
+      <Markdown size='sm' opensInSameTabRegexes={[COURSE_REGEX]} parseUrlsMethod={parseUrl} >[Modify link and open in a new tab](learnn://player/7164/?t=14) </Markdown>
+      <Markdown size='sm' opensInSameTabRegexes={[COURSE_REGEX]} parseUrlsMethod={parseUrl} >[Modify link and open in a new tab](learnn://corso/1) </Markdown>
     </HorizontalStack>
   </AppShell>,
 )

packages/designn/src/components/Markdown.tsx

@@ -51,27 +51,16 @@ export const Markdown = ({ children, overrides, opensInSameTabRegexes, parseUrls
             const url = props.node.url
             const openInSameTab = opensInSameTabRegexes?.some(regex => new RegExp(regex).test(url))
             const parsedUrl = parseUrlsMethod?.(url) 
-            if (openInSameTab) {
-              return (
-                <a href={url}>
-                  {props.children}
-                </a>
-              )
-            }
-            else if (parsedUrl) {
-              return (
-                <a href={parsedUrl}>
-                  {props.children}
-                </a>
-              )
-            }
-            else {
-              return (
-                <a href={url} target='_blank'>
-                  {props.children}
-                </a>
-              )
-            }
+            const openInSameTabParsed = parsedUrl ? opensInSameTabRegexes?.some(regex => new RegExp(regex).test(parsedUrl)) : undefined
+            
+            const href = parsedUrl || url;
+            const target = openInSameTab || openInSameTabParsed ? '' : '_blank';
+
+            return (
+              <a href={href} target={target}>
+                {props.children}
+              </a>
+            );
           },
         }} 
         {...overrides?.reactMarkdownProps}