Skip to content

Edit2#16

Open
DianaRatnikova wants to merge 5 commits intolearnpythonru:mainfrom
DianaRatnikova:edit2
Open

Edit2#16
DianaRatnikova wants to merge 5 commits intolearnpythonru:mainfrom
DianaRatnikova:edit2

Conversation

@DianaRatnikova
Copy link

No description provided.

Copy link
Contributor

@Melevir Melevir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не сдавай такой большой кучей: ошибок много и каждую ошибку ты повторяешь по много раз, получается. Давай этот пр смерджи и приноси по очереди исправления для каждого уровня.

level_1/3.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да не надо использовать этот none_type! Просто пиши None в аннотации и всё

level_2/10.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tuple[int] – это тупл из одного инта, вот такой: (1, ).
Тупл из двух интов – это tuple[int, int]

level_2/3.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут у dict должны быть квадратные скобки, а не фигурные

level_2/4.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут бы уточнить аннотацию

level_2/6.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Первая аннотация неправильная, во второй неверные скобки

level_2/8.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Опять неправильные скобки и тип значений в словаре не тот

level_2/9.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не те скобки и неправильный тип даты

level_3/1.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вокруг вертикальной черты тоже принято пробелы ставить

level_3/2.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Неправильно. Почитай про тайпдикты сперва

level_3/3.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Неправильная аннотация последнего аргумента

@DianaRatnikova
Copy link
Author

Попробую смерджить и пуллреквестнуть исправления

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments