Skip to content

Conversation

@Ashod
Copy link

@Ashod Ashod commented Aug 10, 2020

This adds support for per-document
options, such as enabling/disabling
printing, copying, exporting, etc.
and adds the ability to set a watermark
and other security settings.

These option/settings can be modified
by the document owner. The document locking
logic is also included as a form option to
make it homogeneous with the others.

The options are hidden by default, in a collapsed
section. They are never shown to user without
the ability to modify them.

Screenshot from 2020-09-13 21-11-42

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2020

Codecov Report

Merging #21 into master will decrease coverage by 2.59%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #21      +/-   ##
============================================
- Coverage     14.02%   11.42%   -2.60%     
- Complexity      137      168      +31     
============================================
  Files            17       17              
  Lines           699      858     +159     
============================================
  Hits             98       98              
- Misses          601      760     +159     
Impacted Files Coverage Δ Complexity Δ
moodle/mod/collabora/classes/collabora.php 23.84% <0.00%> (-13.66%) 77.00% <0.00%> (+18.00%) ⬇️
moodle/mod/collabora/view.php 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
moodle/mod/collabora/classes/api.php 0.00% <0.00%> (ø) 46.00% <0.00%> (+13.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc22536...89d0a31. Read the comment docs.

This adds support for per-document
options, such as enabling/disabling
printing, copying, exporting, etc.
and adds the ability to set a watermark
and other security settings.

These option/settings can be modified
by the document owner. The document locking
logic is also included as a form option to
make it homogeneous with the others.

The options are hidden by default, in a collapsed
section. They are never shown to user without
the ability to modify them.
@Ashod Ashod changed the title WIP: Support per-document options Support per-document options Sep 14, 2020
@Ashod Ashod marked this pull request as ready for review September 14, 2020 02:26
@Ashod Ashod marked this pull request as draft September 14, 2020 11:50
@mwuttke
Copy link

mwuttke commented Oct 4, 2020

Hello @Ashod ,

you have made a lot of code changes, witch brings a lot of complexity. All these options should also work with moodle groups and groupings.

Do you have tested all these settings with moodle groups and/or groupings mode too?

Thanks & Greetings,
Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants