From 5fcda533bcc9721c2b0955aed58a287a894abc84 Mon Sep 17 00:00:00 2001
From: David Kang <david@lekko.com>
Date: Fri, 6 Oct 2023 10:35:22 -0700
Subject: [PATCH] Update batch role assignment addition/removal methods

---
 proto/lekko/bff/v1beta1/bff.proto | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/proto/lekko/bff/v1beta1/bff.proto b/proto/lekko/bff/v1beta1/bff.proto
index 15e2adb9..7516c84e 100644
--- a/proto/lekko/bff/v1beta1/bff.proto
+++ b/proto/lekko/bff/v1beta1/bff.proto
@@ -121,7 +121,8 @@ service BFFService {
 
   rpc GetRoleUsers(GetRoleUsersRequest) returns (GetRoleUsersResponse) {}
   // Creates and deletes role assignments accordingly given a list of usernames
-  rpc UpdateRoleUsers(UpdateRoleUsersRequest) returns (UpdateRoleUsersResponse) {}
+  rpc AddUsersToRole(AddUsersToRoleRequest) returns (AddUsersToRoleResponse) {}
+  rpc RemoveUsersFromRole(RemoveUsersFromRoleRequest) returns (RemoveUsersFromRoleResponse) {}
 
   rpc GetRolePermissions(GetRolePermissionsRequest) returns (GetRolePermissionsResponse) {}
   rpc UpsertRolePermission(UpsertRolePermissionRequest) returns (UpsertRolePermissionResponse) {}
@@ -1002,7 +1003,11 @@ message GetTeamRolesResponse {
 
 message UpsertTeamRoleRequest {
   string team_name = 1;
+  // Role name to identify current role or create new role with if one does not exist.
   string role_name = 2;
+  // Can contain an updated role name.
+  // If inserting, role_name and name of updated_role should match.
+  // Team name in this object will be ignored.
   Role updated_role = 3;
 }
 
@@ -1035,13 +1040,21 @@ message GetRoleUsersResponse {
   repeated string usernames = 1;
 }
 
-message UpdateRoleUsersRequest {
+message AddUsersToRoleRequest {
   string team_name = 1;
   string role_name = 2;
   repeated string usernames = 3;
 }
 
-message UpdateRoleUsersResponse {}
+message AddUsersToRoleResponse {}
+
+message RemoveUsersFromRoleRequest {
+  string team_name = 1;
+  string role_name = 2;
+  repeated string usernames = 3;
+}
+
+message RemoveUsersFromRoleResponse {}
 
 message GetRolePermissionsRequest {
   string team_name = 1;