diff --git a/cmd/lekko/feature.go b/cmd/lekko/feature.go index 19a99dd7..bb976ef7 100644 --- a/cmd/lekko/feature.go +++ b/cmd/lekko/feature.go @@ -451,7 +451,9 @@ func configGroup() *cobra.Command { } defer pf.Close() // Write proto file preamble - pf.WriteString(fmt.Sprintf("syntax = \"proto3\";\n\npackage %s;\n\n", protoPkg)) + if _, err := pf.WriteString(fmt.Sprintf("syntax = \"proto3\";\n\npackage %s;\n\n", protoPkg)); err != nil { + return errors.Wrap(err, "write preamble to destination proto file") + } } pf, err := os.OpenFile(protoPath, os.O_APPEND|os.O_WRONLY, 0644) if err != nil { diff --git a/pkg/feature/feature.go b/pkg/feature/feature.go index 3922a430..19f758a7 100644 --- a/pkg/feature/feature.go +++ b/pkg/feature/feature.go @@ -907,17 +907,17 @@ func SuggestGroupedNames(configs ...*Feature) []string { // Builder for a protobuf message definition string type ProtoDefBuilder struct { - sb *strings.Builder - curFieldId int - done bool + sb *strings.Builder + curFieldNumber int + done bool } func NewProtoDefBuilder(name string) *ProtoDefBuilder { sb := &strings.Builder{} sb.WriteString(fmt.Sprintf("message %s {\n", name)) return &ProtoDefBuilder{ - sb: sb, - curFieldId: 1, + sb: sb, + curFieldNumber: 1, } } @@ -947,8 +947,8 @@ func (b *ProtoDefBuilder) AddField(name string, typeName string, comment string) b.sb.WriteString(fmt.Sprintf("// %s\n", cl)) } ffn := b.formatFieldName(name) - b.sb.WriteString(fmt.Sprintf("%s %s = %d;\n", typeName, ffn, b.curFieldId)) - b.curFieldId++ + b.sb.WriteString(fmt.Sprintf("%s %s = %d;\n", typeName, ffn, b.curFieldNumber)) + b.curFieldNumber++ return ffn }