Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Crash when drawing large images #403

Closed
leonlatsch opened this issue Jan 30, 2025 · 2 comments · Fixed by #419
Closed

[Bug] Crash when drawing large images #403

leonlatsch opened this issue Jan 30, 2025 · 2 comments · Fixed by #419
Labels
bug Something isn't working

Comments

@leonlatsch
Copy link
Owner

The app crashes a lot lately due to large images.

This is related to the encryption algorithm not supporting skips in the stream. Meaning all photos are rendered at full size.

We need to find a solution for this. Possible:

Stacktrace:

Exception java.lang.RuntimeException: Canvas: trying to draw too large(201326592bytes) bitmap.
  at android.graphics.RecordingCanvas.throwIfCannotDraw (RecordingCanvas.java:274)
  at android.graphics.BaseRecordingCanvas.drawBitmap (BaseRecordingCanvas.java:153)
  at androidx.compose.ui.graphics.AndroidCanvas.drawImageRect-HPBpro0 (AndroidCanvas.android.kt:275)
  at androidx.compose.ui.graphics.drawscope.CanvasDrawScope.drawImage-AZ2fEMs (CanvasDrawScope.kt:256)
  at androidx.compose.ui.node.LayoutNodeDrawScope.drawImage-AZ2fEMs (Unknown Source:24)
  at androidx.compose.ui.graphics.drawscope.DrawScope.drawImage-AZ2fEMs$default (DrawScope.kt:551)
  at androidx.compose.ui.graphics.painter.BitmapPainter.onDraw (BitmapPainter.kt:93)
  at androidx.compose.ui.graphics.painter.Painter.draw-x_KDEd0 (Painter.kt:212)
  at coil.compose.AsyncImagePainter.onDraw (AsyncImagePainter.kt:272)
  at androidx.compose.ui.graphics.painter.Painter.draw-x_KDEd0 (Painter.kt:212)
  at androidx.compose.ui.draw.PainterNode.draw (PainterModifier.kt:342)
  at androidx.compose.ui.node.LayoutNodeDrawScope.drawDirect-x_KDEd0$ui_release (LayoutNodeDrawScope.kt:105)
  at androidx.compose.ui.node.LayoutNodeDrawScope.draw-x_KDEd0$ui_release (LayoutNodeDrawScope.kt:86)
  at androidx.compose.ui.node.NodeCoordinator.drawContainedDrawModifiers (NodeCoordinator.kt:364)
  at androidx.compose.ui.node.NodeCoordinator.draw (NodeCoordinator.kt:353)
  at androidx.compose.ui.node.LayoutModifierNodeCoordinator.performDraw (LayoutModifierNodeCoordinator.kt:176)
  at androidx.compose.ui.node.NodeCoordinator.drawContainedDrawModifiers (NodeCoordinator.kt:361)
  at androidx.compose.ui.node.NodeCoordinator.access$drawContainedDrawModifiers (NodeCoordinator.kt:54)
  at androidx.compose.ui.node.NodeCoordinator$drawBlock$1$1.invoke (NodeCoordinator.kt:383)
  at androidx.compose.ui.node.NodeCoordinator$drawBlock$1$1.invoke (NodeCoordinator.kt:382)
  at androidx.compose.runtime.snapshots.Snapshot$Companion.observe (Snapshot.kt:2303)
  at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.observe (SnapshotStateObserver.kt:500)
  at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads (SnapshotStateObserver.kt:256)
  at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release (OwnerSnapshotObserver.kt:133)
  at androidx.compose.ui.node.NodeCoordinator$drawBlock$1.invoke (NodeCoordinator.kt:382)
  at androidx.compose.ui.node.NodeCoordinator$drawBlock$1.invoke (NodeCoordinator.kt:380)
  at androidx.compose.ui.platform.RenderNodeApi29.record (RenderNodeApi29.android.kt:209)
  at androidx.compose.ui.platform.RenderNodeLayer.updateDisplayList (RenderNodeLayer.android.kt:335)
  at androidx.compose.ui.platform.AndroidComposeView.dispatchDraw (AndroidComposeView.android.kt:1236)
  at android.view.View.draw (View.java:24221)
  at android.view.View.updateDisplayListIfDirty (View.java:23036)
  at android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4628)
  at android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4601)
  at android.view.View.updateDisplayListIfDirty (View.java:22987)
  at android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4628)
  at android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4601)
  at android.view.View.updateDisplayListIfDirty (View.java:22987)
  at android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4628)
  at android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4601)
  at android.view.View.updateDisplayListIfDirty (View.java:22987)
  at android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4628)
  at android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4601)
  at android.view.View.updateDisplayListIfDirty (View.java:22987)
  at android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4628)
  at android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4601)
  at android.view.View.updateDisplayListIfDirty (View.java:22987)
  at android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4628)
  at android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4601)
  at android.view.View.updateDisplayListIfDirty (View.java:22987)
  at android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4628)
  at android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4601)
  at android.view.View.updateDisplayListIfDirty (View.java:22987)
  at android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4628)
  at android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4601)
  at android.view.View.updateDisplayListIfDirty (View.java:22987)
  at android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4628)
  at android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4601)
  at android.view.View.updateDisplayListIfDirty (View.java:22987)
  at android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4628)
  at android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4601)
  at android.view.View.updateDisplayListIfDirty (View.java:22987)
  at android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4628)
  at android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4601)
  at android.view.View.updateDisplayListIfDirty (View.java:22987)
  at android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4628)
  at android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4601)
  at android.view.View.updateDisplayListIfDirty (View.java:22987)
  at android.view.ThreadedRenderer.updateViewTreeDisplayList (ThreadedRenderer.java:713)
  at android.view.ThreadedRenderer.updateRootDisplayList (ThreadedRenderer.java:719)
  at android.view.ThreadedRenderer.draw (ThreadedRenderer.java:821)
  at android.view.ViewRootImpl.draw (ViewRootImpl.java:5571)
  at android.view.ViewRootImpl.performDraw (ViewRootImpl.java:5233)
  at android.view.ViewRootImpl.performTraversals (ViewRootImpl.java:4268)
  at android.view.ViewRootImpl.doTraversal (ViewRootImpl.java:2765)
  at android.view.ViewRootImpl$TraversalRunnable.run (ViewRootImpl.java:10219)
  at android.view.Choreographer$CallbackRecord.run (Choreographer.java:1544)
  at android.view.Choreographer$CallbackRecord.run (Choreographer.java:1553)
  at android.view.Choreographer.doCallbacks (Choreographer.java:1109)
  at android.view.Choreographer.doFrame (Choreographer.java:994)
  at android.view.Choreographer$FrameDisplayEventReceiver.run (Choreographer.java:1527)
  at android.os.Handler.handleCallback (Handler.java:958)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loopOnce (Looper.java:257)
  at android.os.Looper.loop (Looper.java:368)
  at android.app.ActivityThread.main (ActivityThread.java:8839)
  at java.lang.reflect.Method.invoke
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:572)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1049)
@leonlatsch leonlatsch added the bug Something isn't working label Jan 30, 2025
@leonlatsch
Copy link
Owner Author

Reproducable with this image:

https://upload.wikimedia.org/wikipedia/commons/7/7d/%22_The_Calutron_Girls%22_Y-12_Oak_Ridge_1944_Large_Format_%2832093954911%29_%282%29.jpg

@leonlatsch
Copy link
Owner Author

Interesting observation: Changing the IV size from 16 to 12 bytes seems to fix the error.

@leonlatsch leonlatsch mentioned this issue Feb 17, 2025
Merged
leonlatsch added a commit that referenced this issue Feb 18, 2025
@leonlatsch
Bug: Fix crash with very big images (#419)
b0d9516 
**Description:**

Fixes a crash when displaying very big images.

Closes #403 

Explanation:
Normal downsampling is currently not possible. Because of the nature of
AES/GCM (seems like changing the IV to 12 bytes fixes this, but this is
a much bigger topic)

Applied solution: Read all bytes into memory and provide as a buffered
source from memory. This allows downsampling done by coil, since its
already decrypted in memory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug: Fix crash with very big images leonlatsch/Photok
1 participant
@leonlatsch