You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@leostera This is awesome sauce! I think the situation has improved for me but not entirely.
I still see an issue from #34 but it happens not so frequently to me. Previously, I had to restart my app 7 times to avoid hanging. Now I need to restart it 7 times to observe hanging, which is an improvement!
At this point, I started thinking that my view function may generate lots of garbage, and the GC struggles to process everything at 60 FPS (default).
I wonder if Mint Tea can add something like has_diff : 'model -> 'model -> bool to t
@chshersh these are good ideas! super open to PRs to do a little diffing here and avoid unnecessary renders.
Also like the idea of passing in config for how Minttea should behave, and probably want it to be a little config record since I can imagine in the future apps that do not take user input (just render things out).
@leostera Agree with the idea of having a config 👍🏻
I can try experimenting with these ideas in my Mint Tea fork to see if they actually work for me (before contributing something that doesn't really fix the problem).
But it may take a while 😅 So don't wait for me!
chshersh
added a commit
to chshersh/minttea
that referenced
this issue
Jun 21, 2024
I still see an issue from #34 but it happens not so frequently to me. Previously, I had to restart my app 7 times to avoid hanging. Now I need to restart it 7 times to observe hanging, which is an improvement!
At this point, I started thinking that my
view
function may generate lots of garbage, and the GC struggles to process everything at 60 FPS (default).I wonder if Mint Tea can add something like
has_diff : 'model -> 'model -> bool
tot
minttea/minttea/app.ml
Lines 1 to 5 in 3e38613
So that it can avoid calling
view
entirely if themodel
didn't change unlike the current implementation where we compare already rendered buffer:minttea/minttea/renderer.ml
Line 26 in 3e38613
Alternatively, exposing the
fps
setting fromstart
may help app developers reduce their resource usage (I don't really need 60 fps)minttea/minttea/minttea.ml
Lines 9 to 26 in 3e38613
Originally posted by @chshersh in #38 (comment)
The text was updated successfully, but these errors were encountered: