Skip to content

Commit 7b553e0

Browse files
committed
Merge branch 'add-issn-data-checking' into 'main'
Check for ISSN before using. See merge request softwares-pkp/plugins_ojs/OASwitchboard!35
2 parents f31d185 + 0adca0e commit 7b553e0

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

classes/messages/P1Pio.php

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -206,16 +206,22 @@ public function getJournalData(): array
206206

207207
$journalData = [
208208
'name' => (string) $journal->getLocalizedName(),
209-
'id' => (string) $this->chooseIssn($journal),
210-
'eissn' => (string) $journal->getData('onlineIssn'),
211-
'issn' => (string) $journal->getData('printIssn')
209+
'id' => (string) $this->chooseIssn($journal)
212210
];
211+
212+
if (!empty($journal->getData('onlineIssn'))) {
213+
$journalData['eissn'] = (string) $journal->getData('onlineIssn');
214+
}
215+
if (!empty($journal->getData('printIssn'))) {
216+
$journalData['issn'] = (string) $journal->getData('printIssn');
217+
}
218+
213219
return $journalData;
214220
}
215221

216-
private function chooseIssn($journal)
222+
private function chooseIssn($journal): string
217223
{
218-
return $journal->getData('onlineIssn') ?: $journal->getData('printIssn') ?: null;
224+
return $journal->getData('onlineIssn') ?: $journal->getData('printIssn') ?: "";
219225
}
220226

221227
public function getContent(): array

version.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@
1212
<version>
1313
<application>OASwitchboard</application>
1414
<type>plugins.generic</type>
15-
<release>2.0.1.5</release>
16-
<date>2024-08-01</date>
15+
<release>2.0.1.6</release>
16+
<date>2024-08-12</date>
1717
</version>

0 commit comments

Comments
 (0)