Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fish.wt.cdf #7

Open
leppott opened this issue Apr 12, 2018 · 5 comments
Open

fish.wt.cdf #7

leppott opened this issue Apr 12, 2018 · 5 comments

Comments

@leppott
Copy link
Owner

leppott commented Apr 12, 2018

Several issues.

  1. Not generic enough. Some variables still hard coded into the function (e.g., always wants 3 groups and they are HUC, EcoRegion, and WS Area).

  2. Function name should lose the "fish" name. Will keep fish.wt.cdf but will hide it.

  3. Includes a subdirectory.

  4. Not every parameter should be defaulted. The data files especially.
@leppott
Copy link
Owner Author

leppott commented Apr 12, 2018

Added error checking for SampleID for presence in both input data frames.

@leppott
Copy link
Owner Author

leppott commented Apr 12, 2018

Removed "keywords"

@leppott
Copy link
Owner Author

leppott commented Apr 12, 2018 •
edited
Loading

Fixed example, WS_Area vs. WS_AREA, in fish.wt.cdf.

68a2cfa

v0.0.1.9003

@leppott
Copy link
Owner Author

leppott commented Apr 16, 2018

Updated as v0.0.2.0000

f2526ca

@leppott
Copy link
Owner Author

leppott commented Apr 16, 2018

Need to "hide" fish.wt.cdf with keyword internal.

That way user's code will still work but new users will not be using the "old" function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leppott