Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/01_basic.t started to fail (with XML::LibXML 2.0129?) #3

Open
eserte opened this issue Mar 23, 2017 · 1 comment
Open

t/01_basic.t started to fail (with XML::LibXML 2.0129?) #3

eserte opened this issue Mar 23, 2017 · 1 comment

Comments

@eserte
Copy link

eserte commented Mar 23, 2017

My smoker systems started to report failures in the test suite:

# parsing chunk '<?xml v'
# parsing chunk 'ersion="1.0"?>'

#   Failed test 'event should be start_document'
#   at t/01_basic.t line 104.
#          got: 'set_document_locator'
#     expected: 'start_document'

#   Failed test 'event should be xml_decl'
#   at t/01_basic.t line 104.
#          got: 'start_document'
#     expected: 'xml_decl'

#   Failed test at t/01_basic.t line 105.
#     Structures begin differing at:
#          $got->{Version} = Does not exist
#     $expected->{Version} = '1.0'

#   Failed test 'event should be start_prefix_mapping'
#   at t/01_basic.t line 104.
#          got: 'xml_decl'
#     expected: 'start_prefix_mapping'

#   Failed test at t/01_basic.t line 105.
#     Structures begin differing at:
#          $got->{NamespaceURI} = Does not exist
#     $expected->{NamespaceURI} = 'http://foobar.com'
# parsing chunk '<foo xml'
# parsing chunk 'ns="http://foobar.com">'

#   Failed test 'event should be start_element'
#   at t/01_basic.t line 104.
#          got: 'start_prefix_mapping'
#     expected: 'start_element'

#   Failed test at t/01_basic.t line 105.
#     Structures begin differing at:
#          $got->{Attributes} = Does not exist
#     $expected->{Attributes} = HASH(0x1ea0f18)

#   Failed test at t/01_basic.t line 105.
#     Structures begin differing at:
#          $got->{Attributes}{{}x} = Does not exist
#     $expected->{Attributes}{{}x} = HASH(0x213e510)
# parsing chunk '<'
# parsing chunk 'bar x="1"'
# parsing chunk '>'

#   Failed test at t/01_basic.t line 105.
#     Structures begin differing at:
#          $got->{Name} = 'bar'
#     $expected->{Name} = 'baz'
# parsing chunk '<baz>whoopla</b'

#   Failed test 'event should be characters'
#   at t/01_basic.t line 104.
#          got: 'start_element'
#     expected: 'characters'

#   Failed test at t/01_basic.t line 105.
#     Structures begin differing at:
#          $got->{Name} = 'baz'
#     $expected->{Name} = Does not exist

#   Failed test 'event should be end_element'
#   at t/01_basic.t line 104.
#          got: 'characters'
#     expected: 'end_element'

#   Failed test at t/01_basic.t line 105.
#     Structures begin differing at:
#          $got->{Name} = Does not exist
#     $expected->{Name} = 'baz'
# parsing chunk 'az>'

#   Failed test at t/01_basic.t line 105.
#     Structures begin differing at:
#          $got->{LocalName} = 'baz'
#     $expected->{LocalName} = 'bar'
# parsing chunk '<'
# parsing chunk '/'
# parsing chunk 'bar>'

#   Failed test at t/01_basic.t line 105.
#     Structures begin differing at:
#          $got->{Name} = 'bar'
#     $expected->{Name} = 'foo'
# parsing chunk '</foo>'

#   Failed test 'event should be end_prefix_mapping'
#   at t/01_basic.t line 104.
#          got: 'end_element'
#     expected: 'end_prefix_mapping'

#   Failed test at t/01_basic.t line 105.
#     Structures begin differing at:
#          $got->{LocalName} = 'foo'
#     $expected->{LocalName} = Does not exist

#   Failed test 'event should be '
#   at t/01_basic.t line 104.
#          got: 'end_prefix_mapping'
#     expected: undef

#   Failed test at t/01_basic.t line 105.
#     Structures begin differing at:
#          $got->{Prefix} = ''
#     $expected->{Prefix} = Does not exist
# Looks like you planned 23 tests but ran 25.
# Looks like you failed 19 tests of 25 run.
t/01_basic.t .... 
Dubious, test returned 19 (wstat 4864, 0x1300)
Failed 17/23 subtests 

Statistical analysis suggests that the failures happen only with XML::LibXML 2.0129 (@shlomif: FYI):

****************************************************************
Regression 'mod:XML::LibXML'
****************************************************************
Name           	       Theta	      StdErr	 T-stat
[0='const']    	      1.0000	      0.0000	26624293896831908.00
[1='eq_2.0108']	      0.0000	      0.0000	   0.43
[2='eq_2.0113']	      0.0000	      0.0000	   0.57
[3='eq_2.0116']	      0.0000	      0.0000	   1.43
[4='eq_2.0117']	      0.0000	      0.0000	   0.62
[5='eq_2.0118']	      0.0000	      0.0000	   0.98
[6='eq_2.0121']	      0.0000	      0.0000	   1.01
[7='eq_2.0122']	      0.0000	      0.0000	   1.42
[8='eq_2.0123']	      0.0000	      0.0000	   1.28
[9='eq_2.0124']	      0.0000	      0.0000	   1.32
[10='eq_2.0125']	      0.0000	      0.0000	   1.14
[11='eq_2.0126']	      0.0000	      0.0000	   1.39
[12='eq_2.0127']	      0.0000	      0.0000	   0.85
[13='eq_2.0128']	      0.0000	      0.0000	   0.00
[14='eq_2.0129']	     -1.0000	      0.0000	-25324754955419304.00

R^2= 1.000, N= 211, K= 15


@eserte
Copy link
Author

eserte commented Mar 30, 2018

It looks like this is caused by this change: https://metacpan.org/changes/release/SHLOMIF/XML-LibXML-2.0129#L6

- Add support for the set_document_locator() SAX method .
   - Thanks to Alexander Batyrshin for the pull-request.

eserte added a commit to eserte/XML-LibXML-SAX-ChunkParser that referenced this issue Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant