Merge pull request #6 from letournel/scrutinizer-fixes

fix: travis CI build and some scrutinzer feedback

Author: letournel

.travis.yml

@@ -1,15 +1,13 @@
+dist: precise
 language: php
-
 php:
     - 5.3
     - 5.4
     - 5.5
     - 5.6
     - 7.0
     - 7.1
-
 before_script:
     - composer install --dev
-
 script:
     - phpunit

src/Converters/Grid/ASCIISyntax.php

@@ -98,9 +98,11 @@ public function convertToSyntaxWithPath(NodeGrid $grid, NodePath $path)
 
     public function findAndCreateNode($syntax, $charToFind)
     {
-        for($x = 0; $x < count($syntax); $x++)
+        $xCount = count($syntax);
+        for($x = 0; $x < $xCount; $x++)
         {
-            for($y = 0; $y < count($syntax[$x]); $y++)
+            $yCount = count($syntax[$x]);
+            for($y = 0; $y < $yCount; $y++)
             {
                 if($syntax[$x][$y] === $charToFind)
                 {
@@ -113,9 +115,11 @@ public function findAndCreateNode($syntax, $charToFind)
     public function findAndCreateNodes($syntax, $charToFind)
     {
         $nodes = array();
-        for($x = 0; $x < count($syntax); $x++)
+        $xCount = count($syntax);
+        for($x = 0; $x < $xCount; $x++)
         {
-            for($y = 0; $y < count($syntax[$x]); $y++)
+            $yCount = count($syntax[$x]);
+            for($y = 0; $y < $yCount; $y++)
             {
                 if($syntax[$x][$y] === $charToFind)
                 {

src/Converters/Grid/DeclarativeSyntax.php

@@ -9,11 +9,36 @@ class DeclarativeSyntax implements ConverterGrid
 {
     public function convertToGrid($syntax)
     {
-        
+        throw new \RuntimeException('Not implemented');
+    }
+	
+    public function convertToMatrix($syntax)
+    {
+        throw new \RuntimeException('Not implemented');
     }
 
     public function convertToSyntax(NodeGrid $map)
     {
-        
+        throw new \RuntimeException('Not implemented');
+    }
+    
+    public function convertToSyntaxWithPath(NodeGrid $grid, NodePath $path)
+    {
+        throw new \RuntimeException('Not implemented');
+    }
+    
+    public function findAndCreateNode($syntax, $charToFind)
+    {
+        throw new \RuntimeException('Not implemented');
+    }
+    
+    public function findAndCreateNodes($syntax, $charToFind)
+    {
+        throw new \RuntimeException('Not implemented');
+    }
+    
+    public function generateNodePath($matrix)
+    {
+        throw new \RuntimeException('Not implemented');
     }
 }