Skip to content

Commit e0e3164

Browse files
authored
Merge pull request #1254 from liabru/runner-2
Improve Matter.Runner
2 parents 0b131a4 + aba0e9e commit e0e3164

File tree

9 files changed

+467
-123
lines changed

9 files changed

+467
-123
lines changed

demo/src/Compare.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,6 @@ var compare = function(examples, isDev) {
116116
ticks += 1;
117117

118118
var demoBuildInstance = demoBuild.example.instance;
119-
runner.isFixed = demoBuildInstance.runner.isFixed = true;
120119
runner.delta = demoBuildInstance.runner.delta = 1000 / 60;
121120

122121
window.Matter = MatterBuild;

demo/src/Demo.js

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,22 @@ var demo = function(examples, isDev) {
4141
document.title = 'Matter.js Demo' + (isDev ? ' ・ Dev' : '');
4242

4343
if (isDev) {
44+
// add delta control
45+
Matter.Common.chainPathAfter(MatterTools, 'Gui.create', function() {
46+
this.datGui.__folders["Engine"]
47+
.add(demo, "delta", 0, 1000 / 55)
48+
.onChange(function() {
49+
var runner = demo.example.instance.runner;
50+
runner.delta = demo.delta;
51+
})
52+
.step(0.001)
53+
.listen();
54+
});
55+
56+
Matter.after('Runner.create', function() {
57+
demo.delta = this.delta;
58+
});
59+
4460
// add compare button
4561
var buttonSource = demo.dom.buttonSource,
4662
buttonCompare = buttonSource.cloneNode(true);

examples/index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ module.exports = {
4141
stress2: require('./stress2.js'),
4242
stress3: require('./stress3.js'),
4343
stress4: require('./stress4.js'),
44+
substep: require('./substep.js'),
4445
svg: require('./svg.js'),
4546
terrain: require('./terrain.js'),
4647
timescale: require('./timescale.js'),

examples/stress3.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,7 @@ Example.stress3 = function() {
3434
Render.run(render);
3535

3636
// create runner
37-
var runner = Runner.create({
38-
isFixed: true
39-
});
37+
var runner = Runner.create();
4038
Runner.run(runner, engine);
4139

4240
// add bodies

examples/stress4.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@ Example.stress4 = function() {
3535
Render.run(render);
3636

3737
// create runner
38-
var runner = Runner.create({
39-
isFixed: true
40-
});
38+
var runner = Runner.create();
4139

4240
Runner.run(runner, engine);
4341

examples/substep.js

Lines changed: 122 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,122 @@
1+
var Example = Example || {};
2+
3+
Example.substep = function() {
4+
var Engine = Matter.Engine,
5+
Render = Matter.Render,
6+
Runner = Matter.Runner,
7+
Events = Matter.Events,
8+
Composite = Matter.Composite,
9+
MouseConstraint = Matter.MouseConstraint,
10+
Mouse = Matter.Mouse,
11+
Bodies = Matter.Bodies;
12+
13+
// create engine
14+
var engine = Engine.create(),
15+
world = engine.world;
16+
17+
// create renderer
18+
var render = Render.create({
19+
element: document.body,
20+
engine: engine,
21+
options: {
22+
width: 800,
23+
height: 600,
24+
wireframes: false,
25+
showDebug: true,
26+
background: '#000',
27+
pixelRatio: 2
28+
}
29+
});
30+
31+
Render.run(render);
32+
33+
// create runner with higher precision timestep (requires >= v0.20.0 beta)
34+
var runner = Runner.create({
35+
// 600Hz delta = 1.666ms = 10upf @ 60fps (i.e. 10x default precision)
36+
delta: 1000 / (60 * 10),
37+
// 50fps minimum performance target (i.e. budget allows up to ~20ms execution per frame)
38+
maxFrameTime: 1000 / 50
39+
});
40+
41+
Runner.run(runner, engine);
42+
43+
// demo substepping using very thin bodies (than is typically recommended)
44+
Composite.add(world, [
45+
Bodies.rectangle(250, 250, 300, 1.25, {
46+
frictionAir: 0,
47+
friction: 0,
48+
restitution: 0.9,
49+
angle: 0.5,
50+
render: {
51+
lineWidth: 0.5,
52+
fillStyle: '#f55a3c'
53+
}
54+
}),
55+
Bodies.circle(200, 200, 2.25, {
56+
frictionAir: 0,
57+
friction: 0,
58+
restitution: 0.9,
59+
angle: 0.5,
60+
render: {
61+
fillStyle: '#fff'
62+
}
63+
})
64+
]);
65+
66+
// add bodies
67+
Composite.add(world, [
68+
Bodies.rectangle(400, 0, 800, 50, { isStatic: true, render: { visible: false } }),
69+
Bodies.rectangle(400, 600, 800, 50, { isStatic: true, render: { visible: false } }),
70+
Bodies.rectangle(800, 300, 50, 600, { isStatic: true, render: { visible: false } }),
71+
Bodies.rectangle(0, 300, 50, 600, { isStatic: true, render: { visible: false } })
72+
]);
73+
74+
// scene animation
75+
Events.on(engine, 'afterUpdate', function(event) {
76+
engine.gravity.scale = 0.00035;
77+
engine.gravity.x = Math.cos(engine.timing.timestamp * 0.0005);
78+
engine.gravity.y = Math.sin(engine.timing.timestamp * 0.0005);
79+
});
80+
81+
// add mouse control
82+
var mouse = Mouse.create(render.canvas),
83+
mouseConstraint = MouseConstraint.create(engine, {
84+
mouse: mouse,
85+
constraint: {
86+
stiffness: 0.2,
87+
render: {
88+
visible: false
89+
}
90+
}
91+
});
92+
93+
Composite.add(world, mouseConstraint);
94+
95+
// keep the mouse in sync with rendering
96+
render.mouse = mouse;
97+
98+
// fit the render viewport to the scene
99+
Render.lookAt(render, {
100+
min: { x: 0, y: 0 },
101+
max: { x: 800, y: 600 }
102+
});
103+
104+
// context for MatterTools.Demo
105+
return {
106+
engine: engine,
107+
runner: runner,
108+
render: render,
109+
canvas: render.canvas,
110+
stop: function() {
111+
Matter.Render.stop(render);
112+
Matter.Runner.stop(runner);
113+
}
114+
};
115+
};
116+
117+
Example.substep.title = 'High Substeps (Low Delta)';
118+
Example.substep.for = '>=0.20.0';
119+
120+
if (typeof module !== 'undefined') {
121+
module.exports = Example.substep;
122+
}

src/core/Engine.js

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ var Body = require('../body/Body');
2424

2525
(function() {
2626

27+
Engine._deltaMax = 1000 / 60;
28+
2729
/**
2830
* Creates a new engine. The options parameter is an object that specifies any properties you wish to override the defaults.
2931
* All properties have default values, and many are pre-calculated automatically based on other properties.
@@ -51,7 +53,8 @@ var Body = require('../body/Body');
5153
timestamp: 0,
5254
timeScale: 1,
5355
lastDelta: 0,
54-
lastElapsed: 0
56+
lastElapsed: 0,
57+
lastUpdatesPerFrame: 0
5558
}
5659
};
5760

@@ -89,6 +92,13 @@ var Body = require('../body/Body');
8992
timestamp = timing.timestamp,
9093
i;
9194

95+
// warn if high delta
96+
if (delta > Engine._deltaMax) {
97+
Common.warnOnce(
98+
'Matter.Engine.update: delta argument is recommended to be less than or equal to', Engine._deltaMax.toFixed(3), 'ms.'
99+
);
100+
}
101+
92102
delta = typeof delta !== 'undefined' ? delta : Common._baseDelta;
93103
delta *= timing.timeScale;
94104

0 commit comments

Comments
 (0)