diff --git a/.github/workflows/deploy.yaml b/.github/workflows/deploy.yaml index a4bc357..0a4290a 100644 --- a/.github/workflows/deploy.yaml +++ b/.github/workflows/deploy.yaml @@ -5,9 +5,9 @@ on: branches: - demo -# permissions: -# id-token: write # Needed to modify JWT token for OIDC -# contents: read # Needed for actions/checkout +permissions: + id-token: write # Needed to modify JWT token for OIDC + contents: read # Needed for actions/checkout jobs: run: @@ -29,10 +29,10 @@ jobs: - name: Configure AWS credentials uses: aws-actions/configure-aws-credentials@50ac8dd1e1b10d09dac7b8727528b91bed831ac0 # v3 with: - aws-access-key-id: ${{ secrets.PERSONAL_ACCESS_KEY }} - aws-secret-access-key: ${{ secrets.PERSONAL_SECRET_ACCESS_KEY }} - role-to-assume: ${{ secrets.ROLE_TO_ASSUME }} - # role-to-assume: ${{ vars.OIDC_ROLE }} + # aws-access-key-id: ${{ secrets.PERSONAL_ACCESS_KEY }} + # aws-secret-access-key: ${{ secrets.PERSONAL_SECRET_ACCESS_KEY }} + # role-to-assume: ${{ secrets.ROLE_TO_ASSUME }} + role-to-assume: ${{ vars.OIDC_ROLE }} aws-region: ${{ vars.AWS_REGION }} role-skip-session-tagging: true diff --git a/src/components/ShareForm/ShareForm.tsx b/src/components/ShareForm/ShareForm.tsx index b290c89..fc2686e 100644 --- a/src/components/ShareForm/ShareForm.tsx +++ b/src/components/ShareForm/ShareForm.tsx @@ -42,8 +42,8 @@ const ShareForm = (props: Props) => {
exampleCompany Logo diff --git a/terraform/oidc/main.tf b/terraform/oidc/main.tf index 28ac374..f5899cf 100644 --- a/terraform/oidc/main.tf +++ b/terraform/oidc/main.tf @@ -125,7 +125,9 @@ data "aws_iam_policy_document" "gha_trust_policy" { condition { test = "StringEquals" variable = "token.actions.githubusercontent.com:sub" - values = ["repo:liatrio/keyless-workflow-demo:environment:production"] + # This value will need to be updated to work on a fork of this repo + # https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/about-security-hardening-with-openid-connect#example-subject-claims + values = ["repo:liatrio/keyless-workflow-demo:environment:demo"] } } }