Target netstandard2.0 rather than net472

louis-z · louis-z · commit a318a9101f0f · 2024-07-19T08:39:46.000-04:00
Targeting netstandard2.0 will make LibGit2Sharp more versatile.
diff --git a/LibGit2Sharp/Core/NativeMethods.cs b/LibGit2Sharp/Core/NativeMethods.cs
@@ -66,7 +66,7 @@ private static string GetGlobalSettingsNativeLibraryPath()
             return Path.Combine(nativeLibraryDir, libgit2 + Platform.GetNativeLibraryExtension());
         }
 
-#if NETFRAMEWORK
+#if NETSTANDARD
         private static bool TryUseNativeLibrary() => false;
 #else
         private static bool TryUseNativeLibrary()
diff --git a/LibGit2Sharp/GlobalSettings.cs b/LibGit2Sharp/GlobalSettings.cs
@@ -29,7 +29,7 @@ static GlobalSettings()
 
             nativeLibraryPathAllowed = netFX || netCore;
 
-#if NETFRAMEWORK
+#if NETSTANDARD
             if (netFX)
             {
                 // For .NET Framework apps the dependencies are deployed to lib/win32/{architecture} directory
@@ -40,7 +40,7 @@ static GlobalSettings()
             registeredFilters = new Dictionary<Filter, FilterRegistration>();
         }
 
-#if NETFRAMEWORK
+#if NETSTANDARD
         private static string GetExecutingAssemblyDirectory()
         {
             // Assembly.CodeBase is not actually a correctly formatted
diff --git a/LibGit2Sharp/LibGit2Sharp.csproj b/LibGit2Sharp/LibGit2Sharp.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>net472;net6.0</TargetFrameworks>
+    <TargetFrameworks>netstandard2.0;net6.0</TargetFrameworks>
     <LangVersion>10.0</LangVersion>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <Description>LibGit2Sharp brings all the might and speed of libgit2, a native Git implementation, to the managed world of .NET</Description>

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ private static string GetGlobalSettingsNativeLibraryPath()`
`66`	`66`	`return Path.Combine(nativeLibraryDir, libgit2 + Platform.GetNativeLibraryExtension());`
`67`	`67`	`}`
`68`	`68`
`69`		`-#if NETFRAMEWORK`
	`69`	`+#if NETSTANDARD`
`70`	`70`	`private static bool TryUseNativeLibrary() => false;`
`71`	`71`	`#else`
`72`	`72`	`private static bool TryUseNativeLibrary()`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ static GlobalSettings()`
`29`	`29`
`30`	`30`	`nativeLibraryPathAllowed = netFX \|\| netCore;`
`31`	`31`
`32`		`-#if NETFRAMEWORK`
	`32`	`+#if NETSTANDARD`
`33`	`33`	`if (netFX)`
`34`	`34`	`{`
`35`	`35`	`// For .NET Framework apps the dependencies are deployed to lib/win32/{architecture} directory`
`@@ -40,7 +40,7 @@ static GlobalSettings()`
`40`	`40`	`registeredFilters = new Dictionary<Filter, FilterRegistration>();`
`41`	`41`	`}`
`42`	`42`
`43`		`-#if NETFRAMEWORK`
	`43`	`+#if NETSTANDARD`
`44`	`44`	`private static string GetExecutingAssemblyDirectory()`
`45`	`45`	`{`
`46`	`46`	`// Assembly.CodeBase is not actually a correctly formatted`