style: remove leading '_'

The TypeScript compiler automatically ignores imports, function arguments, type parameter
declarations, and object destructuring variables prefixed with an underscore

https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/
rules/no-unused-vars-experimental.md

Author: libinvarghese

.eslintrc.js

@@ -1,7 +1,14 @@
+const booleanVarPrefix = ['is', 'should', 'has', 'can', 'did', 'will'];
+
 const booleanVariable = {
   types: ['boolean'],
   format: ['PascalCase'],
-  prefix: ['is', 'should', 'has', 'can', 'did', 'will'],
+  prefix: booleanVarPrefix,
+};
+
+const booleanConst = {
+  types: ['boolean'],
+  prefix: booleanVarPrefix.map(prefix => `${prefix.toUpperCase()}_`),
 };
 
 module.exports = {
@@ -62,21 +69,47 @@ module.exports = {
       {
         selector: 'variableLike',
         format: ['camelCase'],
-        leadingUnderscore: 'allow',
+      },
+      {
+        selector: 'variable',
+        modifiers: ['const'],
+        format: ['camelCase'],
+      },
+      {
+        selector: 'variable',
+        modifiers: ['const'],
+        format: ['camelCase'],
+        ...booleanConst,
       },
       {
         selector: 'variable',
         ...booleanVariable,
       },
+      {
+        selector: 'parameter',
+        format: ['camelCase'],
+        leadingUnderscore: 'allow',
+      },
       {
         selector: 'parameter',
         ...booleanVariable,
+        leadingUnderscore: 'allow',
       },
       {
         selector: 'memberLike',
         modifiers: ['private'],
         format: ['camelCase'],
-        leadingUnderscore: 'require',
+      },
+      {
+        selector: 'memberLike',
+        modifiers: ['static', 'readonly'],
+        format: ['UPPER_CASE'],
+      },
+      {
+        selector: 'property',
+        modifiers: ['static', 'readonly'],
+        format: ['UPPER_CASE'],
+        ...booleanConst,
       },
       {
         selector: 'typeLike',

scripts/check-not-staged.ts

@@ -3,11 +3,11 @@ import gitP from 'simple-git';
 const git = gitP();
 
 void (async (): Promise<void> => {
-  const _gitStatus = await git.status();
-  const _notStaged = _gitStatus.files.filter(status => status.working_dir !== ' ');
-  if (_notStaged.length > 0) {
+  const gitStatus = await git.status();
+  const notStaged = gitStatus.files.filter(status => status.working_dir !== ' ');
+  if (notStaged.length > 0) {
     console.error(`Changes not staged present! Please run 'git add' or 'git checkout'!`);
-    _notStaged.map(file => file.path).forEach(file => console.error(file));
+    notStaged.map(file => file.path).forEach(file => console.error(file));
     process.exitCode = 1;
   }
 })();

scripts/githubActionsDepGen.ts

@@ -12,15 +12,15 @@ const ymlDep = safeLoad(ymlDepContent);
 const dependencies = ((ymlDep as any).jobs.dummy.steps as { uses: string }[])
   .map(step => step.uses)
   .reduce((list, dep) => {
-    const _match = /.*\/(.*)@.*/.exec(dep);
+    const match = /.*\/(.*)@.*/.exec(dep);
 
-    if (_match === null) {
+    if (match === null) {
       throw new Error(`Incorrect format for dependency - ${dep}`);
     }
 
-    const _key = _match[1];
+    const key = match[1];
     // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-explicit-any
-    (list as any)[_key] = dep;
+    (list as any)[key] = dep;
 
     return list;
   }, {});

scripts/publish-package.ts

@@ -4,20 +4,20 @@ import { get, set } from 'lodash';
 const packageJSON = require('../package.json');
 
 function deleteUnwantedKeys(): void {
-  const _keysToDelete = ['devDependencies', 'scripts', 'husky'];
+  const keysToDelete = ['devDependencies', 'scripts', 'husky'];
 
   // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-  _keysToDelete.forEach(key => delete packageJSON[key]);
+  keysToDelete.forEach(key => delete packageJSON[key]);
 }
 
 function renameDistPath(): void {
-  const _pathsToFix = ['main', 'bin.recursive-copy'];
+  const pathsToFix = ['main', 'bin.recursive-copy'];
 
-  _pathsToFix.forEach(path => {
+  pathsToFix.forEach(path => {
     // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
-    let _value: string = get(packageJSON, path);
-    _value = _value.replace('dist/', '');
-    set(packageJSON, path, _value);
+    let value: string = get(packageJSON, path);
+    value = value.replace('dist/', '');
+    set(packageJSON, path, value);
   });
 }
 

src/bootstrap-cli.ts

@@ -14,10 +14,10 @@ export async function bootstrapCli(cliArgs?: string[]): Promise<void> {
   } = cliOptionsKeysToCopy.reduce(
     (prev, key) => {
       // eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
-      const _value = (argv as any)[key];
-      if (_value != undefined) {
+      const value = (argv as any)[key];
+      if (value != undefined) {
         // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
-        prev[key] = _value;
+        prev[key] = value;
       }
       return prev;
     },