Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Check Spelling https://github.com/libprima/PRIMA.jl/issues/11 #12

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

zaikunzhang
Copy link
Member

No description provided.

@zaikunzhang zaikunzhang requested a review from emmt October 18, 2023 16:18
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@zaikunzhang zaikunzhang mentioned this pull request Oct 18, 2023
Copy link
Collaborator

@emmt emmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not fully understand all the implications of trigerring this tool. For instance, can we restrict the checks to the comments and the documentation? It nevertheless seems to be useful as it fixed a few typos in the comments (some of these have been fixed in PR #17 so I expect some conflicts).

@zaikunzhang
Copy link
Member Author

[Sorry @emmt , it seems that I edited your comment when I meant to respond to it. It is restored. My response is as follows.]

I do not fully understand all the implications of trigerring this tool. For instance, can we restrict the checks to the comments and the documentation? It nevertheless seems to be useful as it fixed a few typos in the comments (some of these have been fixed in PR #17 so I expect some conflicts).

The scope can be configured by modifying the files in .github/actions/spelling. In particular,

allow.txt: false positives
pattern.txt: patterns to exclude
exclude.txt: files to exclude
I do not know how to ask it to check only specific files. If that is desired, an issue should be open at https://github.com/check-spelling/check-spelling

For instance, can we restrict the checks to the comments

I suppose not. The idea of this action is particular to check the code. It will try to understand your code, and exclude the keywords of the language. This is done by dictionaries corresponding to the language. However, unfortunately, Julia does not have a dictionary yet.

@emmt
Copy link
Collaborator

emmt commented Oct 23, 2023

Let us be pragmatic and add false positives as they appear.

@emmt emmt merged commit 8675139 into libprima:main Oct 23, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants