-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PRIMA bonds does not seem to work #22
Comments
Thank you @AquaPore . Could you show how you called the solvers, and what results you got exactly? |
Thanks for case 1: I did not get any results for case 2 I checked that the optimised parameters were not between the lower and upper limit. |
Thank you @AquaPore . Could you show us exactly how you called the solvers, including the values of the input and output? |
Hi @AquaPore ,
Thank you. I hope I could help, but I would need the above-mentioned information. |
Dear Zaikunzhang, A great thanks for making PRIMA open source. I run sucessfully with BlackBoxOptim and I am looking forward to compare it with PRIMA. In my case I will not use LINCOA or COBYLA as it does not respect the bounds and causes NaN. Here are the values of lower and upper As I can see in your documentation PRIMA there is nowhere mention that we need rhobeg and rhoend values so I did not put them in the keyword. The results are
The warning is important to remove because it slows down the optimisation Many thanks for your help, |
See te table of the Keywords.
Could you try one (and only one) of the following? This should remove the warning.
OR:
|
Thanks for your help: Unfortunately option 1 did not work Option 2 did not work Option 3 did not work The warning Thanks, |
Hi Joseph,
First of all, the scale should be If things still do not work after setting Set
but do not set any value to Thank you. BTW, my name is Zaikun ZHANG. People call me Zaikun (preferred), Prof. Zhang (only my students), or simply @zaikunzhang , or just "Hi", but not Zaikunzhang; I appreciate your efforts. |
Thanks Zaikun ZHANG, I am optimizing 6 parameters so the scale should be a vector so I propose Thanks the following now works but not sure it is the most efficient for simple curve fitting: `elseif 🎏_Model == :Prima X, info = PRIMA.bobyqa(X -> optIndivSoil.OF_HYDROLAB(hydro, iZ, K_KΨobs, N_KΨobs, N_θΨobs, Of_Sample, optim, option, optionₘ, param, X, θ_θΨobs, Ψ_KΨobs, Ψ_θΨobs), Initial; xl=Lower, xu=Upper, rhobeg=rhobeg, rhoend=rhoend)` The following code works, which parameter controles the accuracy of the simulation? A great thanks, |
Thank you Joseph for the explanation.
It is a pleasure to help.
However, your Note that I am not a Julia user. I have absolutely no knowledge of the syntax of this language.
I would not be surprised if it does not work quite well. According to the bounds
N.B.: If you take this setting, you should set all the three parameters together as above.
It is Thanks. Zaikun |
Hello Zaikun and Joseph,
The Julia interface of PRIM forbid (see https://github.com/libprima/PRIMA.jl/blob/bda4ba7ae787089330e7a48db3df7943d5de11ad/src/PRIMA.jl#L389C1-L395C1) having different sizes for the variables, any of the bounds, or the scaling factors. So I do not see how this could be possible. @AquaPore can you provide us with a complete example code so that we can fix this issue please? |
Sorry I optimised with 6 parameters. ` Lower, Upper = optimizeOptim.SEARCHRANGE_OPTIM(optionₘ, optim)
` It works with no warning but BlackBoxOptim outperforms the accuracy. I am performing some compex optimisation of soils so it is challanging to show my problem. in a few lines |
Thank you, Joseph. Could you by any chance show us the actual values of Your previously mentioned In addition, if you are concerned about the accuracy, you could try setting Thanks. |
Hello,
Can you be more specific about the precision? As pointed by Zaikun, the |
I would like to close this issue if possible. @AquaPore did you make any tests with the parameters suggested by @zaikunzhang to improve the precision? |
Bonjour Eric,
Merci.
Please apologise for not being very helpful, and indeed, you can close the
issue.
In my case study the BlackBox OPtim seems to given better results but I am
sure because I did not have a good understanding how your optimisation
works.
https://github.com/robertfeldt/BlackBoxOptim.jl
With kindness,
Joseph
…On Thu, 17 Oct 2024 at 05:08, Éric Thiébaut ***@***.***> wrote:
I would like to close this issue if possible.
@AquaPore <https://github.com/AquaPore> did you make any tests with the
parameters suggested by @zaikunzhang <https://github.com/zaikunzhang> to
improve the precision?
—
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3ONCV2JCOKQMYNO5W4HJSLZ32FOVAVCNFSM6AAAAABQB2LG32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJXGI4DANBVGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thank you @AquaPore for letting us know. I am closing the issue... |
Dear Prima,
A great thanks for developing so powerfull optimisation.
The optimiser BOBYQA
X, info = PRIMA.bobyqa(X -> optIndivSoil.OF_HYDROLAB(hydro, iZ, K_KΨobs, N_KΨobs, N_θΨobs, Of_Sample, optim, option, optionₘ, param, X, θ_θΨobs, Ψ_KΨobs, Ψ_θΨobs), Initial; xl=Lower, xu=Upper, iprint=false)
I get the following warning
Warning: BOBYQA: Invalid RHOBEG; BOBYQA requires 0 < RHOBEG <= MINVAL(XU-XL)/2; it is set to MINVAL(XU-XL)/4.
Warning: BOBYQA: Invalid RHOEND; it should be a positive number and RHOEND <= RHOBEG; it is set to 1.000000000000000E-006.
The optimiser lincoa
The X propososed parameters are unfortunately not between
Lower
andUpper
, did i set the model properly?Thanks,
Joseph
The text was updated successfully, but these errors were encountered: