Skip to content

Commit 0babf97

Browse files
committed
Added toggle for bookmarks menu in settings #861
1 parent 5a105da commit 0babf97

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

src/pages/options/widgets/general.js

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,18 @@ redirectOnlyInIncognitoElement.addEventListener('change', event => {
109109
setOption('redirectOnlyInIncognito', 'checkbox', event)
110110
})
111111

112+
const bookmarksMenuElement = document.getElementById('bookmarksMenu')
113+
bookmarksMenuElement.addEventListener('change', async event => {
114+
if (event.target.checked)
115+
bookmarksMenuElement.checked = await browser.permissions.request({
116+
permissions: ["bookmarks"]
117+
})
118+
else
119+
bookmarksMenuElement.checked = !await browser.permissions.remove({
120+
permissions: ["bookmarks"]
121+
})
122+
})
123+
112124
let themeElement = document.getElementById("theme")
113125
themeElement.addEventListener("change", event => {
114126
setOption("theme", "select", event)
@@ -136,7 +148,8 @@ for (const service in config.services) {
136148
let options = await utils.getOptions()
137149
themeElement.value = options.theme
138150
fetchInstancesElement.value = options.fetchInstances
139-
redirectOnlyInIncognitoElement.target.checked = options.redirectOnlyInIncognito
151+
redirectOnlyInIncognitoElement.checked = options.redirectOnlyInIncognito
152+
bookmarksMenuElement.checked = await browser.permissions.contains({ permissions: ["bookmarks"] })
140153
for (const service in config.services) document.getElementById(service).checked = options.popupServices.includes(service)
141154

142155
instanceTypeElement.addEventListener("change", event => {

src/pages/options/widgets/general.pug

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@ section(class="block-option" id="general_page")
2121
label(for='redirectOnlyInIncognito' data-localise="__MSG_redirectOnlyInIncognito__") Redirect Only in Incognito
2222
input(id='redirectOnlyInIncognito' type="checkbox")
2323

24+
div(class="block block-option")
25+
label(for='bookmarksMenu' data-localise="__MSG_bookmarksMenu__") Bookmarks menu
26+
input(id='bookmarksMenu' type="checkbox")
27+
2428
div(class="block block-option")
2529
label(data-localise="__MSG_excludeFromRedirecting__") Excluded from redirecting
2630

0 commit comments

Comments
 (0)