Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker hub image publishing #43

Open
Beanow opened this issue Jun 13, 2022 · 8 comments
Open

Docker hub image publishing #43

Beanow opened this issue Jun 13, 2022 · 8 comments

Comments

@Beanow
Copy link

Beanow commented Jun 13, 2022

Description

Automatically publishing images, ideally using the same librespeed/speedtest-go naming allows an easy 'straight from the source' install. Some CI, like GH actions makes this pretty easy. Especially when you're already maintaining a Dockerfile.

Why it should be implemented

I believe, https://hub.docker.com/r/mickkael/librespeed-go is the closest to an "official" image being published?
It's a bit of a mess of people building their own speedtest-go/librespeed-go images.
And the mickkael/librespeed-go one seems out of date, rocking v1.1.3, so I assume it is being pushed manually from a dev machine.


For reference a modern multi-arch GH action might look something like this. thomseddon/traefik-forward-auth#275

@masx200
Copy link

masx200 commented Jul 8, 2022

https://hub.docker.com/r/chishin/speedtest-go-zh

@Beanow
Copy link
Author

Beanow commented Jul 8, 2022

☝️ ⚠️ PSA be careful running random code you've not reviewed and have about 10 downloads image

It should prove my point why it'd be great to have an up-to-date official image:

It's a bit of a mess of people building their own speedtest-go/librespeed-go images.

@mickkael
Copy link
Contributor

Let me make a GH action workflow to publish directly on this github registry. I'll get a Pull request

@onedr0p
Copy link
Contributor

onedr0p commented Jan 13, 2023

@mickkael any luck?

✖ docker pull ghcr.io/librespeed/speedtest-go:v1.1.5
Error response from daemon: Head "https://ghcr.io/v2/librespeed/speedtest-go/manifests/v1.1.5": unauthorized

✖ docker pull ghcr.io/librespeed/speedtest-go:1.1.5
Error response from daemon: Head "https://ghcr.io/v2/librespeed/speedtest-go/manifests/1.1.5": unauthorized

✖ docker pull ghcr.io/librespeed/speedtest-go:latest
Error response from daemon: Head "https://ghcr.io/v2/librespeed/speedtest-go/manifests/latest": unauthorized

@mickkael
Copy link
Contributor

mickkael commented Jan 15, 2023

@onedr0p
Copy link
Contributor

onedr0p commented Jan 15, 2023

@mickkael is your fork the successor to this repo?

@mickkael
Copy link
Contributor

Not at all.
I've built on the fork, as I don't have any permission on the main repo.
I've submitted the PR for the same action to be triggered on main repo

@onedr0p
Copy link
Contributor

onedr0p commented Jan 15, 2023

oh that's a bummer, I guess I'll fork it too and merge some of the PRs here into my fork until the maintainers come back to address them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants