Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-endpoints.py not finding all missing endpoints #10

Closed
trevorbayless opened this issue May 11, 2023 · 1 comment · Fixed by #17
Closed

check-endpoints.py not finding all missing endpoints #10

trevorbayless opened this issue May 11, 2023 · 1 comment · Fixed by #17
Assignees
Labels
bug Something isn't working

Comments

@trevorbayless
Copy link
Member

trevorbayless commented May 11, 2023

Describe the issue

The check-endpoints.py script is not finding all missing endpoints.

Endpoints not found as missing by check-endpoints.py:
/oauth
/api/token

Related to #6

@trevorbayless trevorbayless added the bug Something isn't working label May 11, 2023
@trevorbayless trevorbayless changed the title Anomalies with check-endpoints.py check-endpoints.py not finding all missing endpoints May 11, 2023
@thegrapesoda
Copy link
Contributor

This is a function of how the regex search is being performed. It searches for each item without the leading '/', and it doesn't search in the context of the item being used as an exact path.

So "/oauth" becomes "oauth" - which exists as a string on its own elsewhere in clients.py. "/api/token" becomes "api/token", which has a child ("api/token/test") in clients.py, which is being counted as a match because the string "api/token" is being found in the string "api/token/test").

If someone wants to assign to me, they can - I'm going to attempt the pull request later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants