Skip to content

Use JDK 21 images #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Use JDK 21 images #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e88985
use jdk 21 images
fitztrev Oct 14, 2023
a439b8f
Merge branch 'main' into jdk-21
trevorbayless Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"image": "sbtscala/scala-sbt:eclipse-temurin-focal-17.0.8.1_1_1.9.6_3.3.1",
"image": "sbtscala/scala-sbt:eclipse-temurin-jammy-21_35_1.9.6_3.3.1",
"customizations": {
"vscode": {
"extensions": [
Expand Down
10 changes: 5 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ docker compose run --rm ui bash -c "cd /pgn-viewer && pnpm install && pnpm run f

# sbt scalafmtAll
docker run --rm -v $(pwd)/repos/lila:/lila \
sbtscala/scala-sbt:eclipse-temurin-focal-17.0.8.1_1_1.9.6_3.3.1 \
sbtscala/scala-sbt:eclipse-temurin-jammy-21_35_1.9.6_3.3.1 \
bash -c "cd /lila && sbt scalafmtAll"
```

Expand All @@ -124,7 +124,7 @@ docker run --rm -v $(pwd)/repos/berserk:/berserk -v $(pwd)/scripts:/scripts pyth
### Scala Metals (IDE helper):

1. In VS Code, open this `lila-docker` project and install the [Dev Containers extension](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers)
2. Cmd+Shift+P > "Dev Containers: Reopen in Container"
2. Cmd+Shift+P > "Dev Containers: Rebuild and Reopen in Container"
3. A new VS Code window will open, attached to the container instead of your host machine
4. File > Open Folder > "/workspaces/lila-docker/repos/lila" (or whichever Scala project you want to work on)
5. Install + Enable the Scala Metals extension (Cmd+Shift+X > "Scala (Metals)")
Expand Down Expand Up @@ -162,17 +162,17 @@ Other Scalachess commands:
```bash
## compile
docker run --rm -v $(pwd)/repos/scalachess:/mnt \
sbtscala/scala-sbt:eclipse-temurin-focal-17.0.8.1_1_1.9.6_3.3.1 \
sbtscala/scala-sbt:eclipse-temurin-jammy-21_35_1.9.6_3.3.1 \
bash -c "cd /mnt && sbt compile"

## test
docker run --rm -v $(pwd)/repos/scalachess:/mnt \
sbtscala/scala-sbt:eclipse-temurin-focal-17.0.8.1_1_1.9.6_3.3.1 \
sbtscala/scala-sbt:eclipse-temurin-jammy-21_35_1.9.6_3.3.1 \
bash -c "cd /mnt && sbt testKit/test"

## package
docker run --rm -v $(pwd)/repos/scalachess:/mnt \
sbtscala/scala-sbt:eclipse-temurin-focal-17.0.8.1_1_1.9.6_3.3.1 \
sbtscala/scala-sbt:eclipse-temurin-jammy-21_35_1.9.6_3.3.1 \
bash -c "cd /mnt && sbt package"
```

Expand Down
2 changes: 1 addition & 1 deletion docker/lila-search.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM sbtscala/scala-sbt:eclipse-temurin-17.0.5_8_1.8.2_2.13.10
FROM sbtscala/scala-sbt:eclipse-temurin-jammy-21_35_1.9.6_2.13.12

WORKDIR /lila-search

Expand Down
2 changes: 1 addition & 1 deletion docker/lila-ws.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM sbtscala/scala-sbt:eclipse-temurin-focal-17.0.8.1_1_1.9.6_3.3.1
FROM sbtscala/scala-sbt:eclipse-temurin-jammy-21_35_1.9.6_3.3.1

WORKDIR /lila-ws

Expand Down
2 changes: 1 addition & 1 deletion docker/lila.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM sbtscala/scala-sbt:eclipse-temurin-focal-17.0.8.1_1_1.9.6_3.3.1
FROM sbtscala/scala-sbt:eclipse-temurin-jammy-21_35_1.9.6_3.3.1

WORKDIR /lila

Expand Down